event icon indicating copy to clipboard operation
event copied to clipboard
verified publisher icon OCA

[17.0][MIG] event_project

Open rrebollo opened this issue 1 year ago • 1 comments

standard migration from v16 with several coding improvements:

  • split business logic between event and project models
  • sql constraint to avoid settle same project for different events (test added)
  • refactor tests
  • improve documentation
  • replace custom project.task action by built-in
  • add project search capabilities to event search view
  • ensure groups event manager in views

rrebollo avatar Dec 27 '24 20:12 rrebollo

@jelenapoblet Could you please do the functional review? I think the documentation could be improved. Maybe after testing it, you can come up with some specific suggestions.

rrebollo avatar Dec 30 '24 12:12 rrebollo

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar May 11 '25 12:05 github-actions[bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar May 13 '25 08:05 OCA-git-bot

@arielbarreiros96 your suggestion is a nice improvement, but not contemplated in this migration, I would merge this, and if there's an improvement proposition, it could be done in another pr

jelenapoblet avatar May 13 '25 09:05 jelenapoblet

@arielbarreiros96 your suggestion is a nice improvement, but not contemplated in this migration, I would merge this, and if there's an improvement proposition, it could be done in another pr

Indeed it looks more like a later improvement to be done, better to keep the migration clean

arielbarreiros96 avatar May 13 '25 10:05 arielbarreiros96

@arielba1rreiros96 The addon has undergone significant refactoring in recent migrations, which has also led to a reduced scope. Implementing two-way synchronization would indeed be a valuable improvement, but it would be better addressed in a separate PR.

rrebollo avatar May 13 '25 11:05 rrebollo

/ocabot migration event_project

rafaelbn avatar May 19 '25 20:05 rafaelbn

/ocabot merge nobump

pedrobaeza avatar Jun 14 '25 08:06 pedrobaeza

This PR looks fantastic, let's merge it! Prepared branch 17.0-ocabot-merge-pr-423-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot avatar Jun 14 '25 08:06 OCA-git-bot

Congratulations, your PR was merged at 0ae7a38af05b348838ca0b9b68ff0ba2e4c2c9e1. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Jun 14 '25 08:06 OCA-git-bot