edi icon indicating copy to clipboard operation
edi copied to clipboard

[16.0][MIG] account_invoice_import: Migration to 16.0

Open V3st1g3 opened this issue 1 year ago • 4 comments

V3st1g3 avatar Nov 08 '24 14:11 V3st1g3

@bosd @simahawk @njeudy

Hi! I managed to get the tests working. Do you have any advice to improve code coverage?

V3st1g3 avatar Nov 26 '24 17:11 V3st1g3

I also migrated account_invoice_import_invoice2data to expand code coverage.

V3st1g3 avatar Dec 05 '24 13:12 V3st1g3

@V3st1g3 Thanks for your work on this. It's better practive to have one pr per module. Can you separate the account_invoice_import_invoice2data in a separate pr?

FYI I'm working on a big refactor of the invoice2data library. Improved code, tests. Updated googlevision to the latest API and AI support. As well as a new default backend, Which will drop the requirement on poppler. So the library can be installed with a simple pip install.

@alexis-via is to my knowledge working on refactoring the account_invoice_import. Maybe you can combine the efforts to get the new functions and simplifications of the code in here.

bosd avatar Dec 11 '24 12:12 bosd

@bosd It's done, the PR is here: https://github.com/OCA/edi/pull/1095

Thanks for your reply, I'll look into it when I have time. :+1:

V3st1g3 avatar Dec 11 '24 15:12 V3st1g3

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Jun 15 '25 12:06 github-actions[bot]