delivery-carrier
delivery-carrier copied to clipboard
[14.0][FIX] delivery_send_to_shipper_at_operation: Keep delivery_notification_sent set on backorder
If a backorder is created out of a transfer which is marked as delivery_notification_sent = True. The backorder should also be marked as delivery_notification_sent.
@jbaudoux @TDu
Depends on: Fixing tests https://github.com/OCA/delivery-carrier/pull/786
Why can't we simply revert this #720 ?
No it is fine to not copy the value, because move_dest_ids/move_orig_ids will also not copied from a move. In a backorder case the move_orig_ids will be the same as in the new backorder
@mt-software-de I should have added a unittest for my fix https://github.com/OCA/delivery-carrier/pull/720. If you do a partial pack, then you don't want to keep delivery_notification_sent
on the pack backorder.
So, it's a bit more complex...
@mt-software-de I should have added a unittest for my fix #720. If you do a partial pack, then you don't want to keep
delivery_notification_sent
on the pack backorder. So, it's a bit more complex...
For the pack operation backorder it is fine, to not set the delivery_notification_sent
therefore we need to remove
https://github.com/OCA/delivery-carrier/blob/1ec54201e1b6b21761dfc7e831d6a4a3a4990450/delivery_send_to_shipper_at_operation/models/stock_picking.py#L54
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.