delivery-carrier icon indicating copy to clipboard operation
delivery-carrier copied to clipboard

Published 20 hours ago • verified publisher icon OCA

[16.0][IMP] delivery_package_number: add field for auto printing

Open ferran-S73 opened this issue 1 year ago • 10 comments

I know this may be a bit counterintuitive but the print_label base field is used for sending to shipper so making these labels auto printed by this field has caused an issue in some clients that want to have the shipper feature but don't want the number of packages label. Best way I've found to resolve the issue is by creating a dedicated field to configure the auto-printing.

ferran-S73 avatar Jan 16 '24 08:01 ferran-S73

@pedrobaeza anyone from tecnativa to review/give opinion on this please? This is due to the last pr you merged https://github.com/OCA/delivery-carrier/pull/750

ferran-S73 avatar Jan 16 '24 11:01 ferran-S73

@sergio-teruel @CarlosRoca13 didn't you develop something similar on v15?

pedrobaeza avatar Jan 16 '24 12:01 pedrobaeza

Yes!!1

sergio-teruel avatar Jan 16 '24 23:01 sergio-teruel

@ferran-S73 please check 15.0 commits and put this branch up to date with it, and you'll have the feature.

pedrobaeza avatar Jan 17 '24 07:01 pedrobaeza

@ferran-S73 please check 15.0 commits and put this branch up to date with it, and you'll have the feature.

@pedrobaeza @sergio-teruel I can't seem to find the feature you guys are talking about on v15. Could you point towards which commit is missing please?

ferran-S73 avatar Jan 17 '24 07:01 ferran-S73

@pedrobaeza @sergio-teruel just to clarify this a separate field to decide whether the report number of packages should be printed on picking validation, I didn't see any similar feature in any past version. If it does exist could you help me find it?

ferran-S73 avatar Jan 22 '24 07:01 ferran-S73

Hi Ferran, if you follow this steps in v15 or v16 (it was migrated yet). You can test the feature by doing this steps:

  1. Go to picking types.
  2. Set as true Force set number of packages and select the action report that you want to execute.
  3. When going to validate the picking the system will ask you for the number of packages and you will be able to check if you want to print the labels.

On next gif you can see it: example

CarlosRoca13 avatar Jan 22 '24 07:01 CarlosRoca13

Hi Ferran, if you follow this steps in v15 or v16 (it was migrated yet). You can test the feature by doing this steps:

1. Go to picking types.

2. Set as true Force set number of packages and select the action report that you want to execute.

3. When going to validate the picking the system will ask you for the number of packages and you will be able to check if you want to print the labels.

On next gif you can see it: example example

Hi @CarlosRoca13 , thank you for the explanation but that isn't the point of this PR. What we want is to not automatically print the report when the picking is validated through any of it's wizards. That is due to those wizards using the base 'print_label' field and the reason I opted for adding a new field. Yo can try for yourself just validate a picking through a wizard (validate it partially for example) without the force set number of packages field and you'll end up with the report number of packages printed if the print_label field is checked.

ferran-S73 avatar Jan 22 '24 07:01 ferran-S73

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar May 26 '24 12:05 github-actions[bot]

Hi Ferran, if you follow this steps in v15 or v16 (it was migrated yet). You can test the feature by doing this steps:

1. Go to picking types.

2. Set as true Force set number of packages and select the action report that you want to execute.

3. When going to validate the picking the system will ask you for the number of packages and you will be able to check if you want to print the labels.

On next gif you can see it: example

    [
      
        ![example](https://private-user-images.githubusercontent.com/35952655/298502097-2add2f36-e798-49bb-9e8f-5068840d6022.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDU5MDk5NDMsIm5iZiI6MTcwNTkwOTY0MywicGF0aCI6Ii8zNTk1MjY1NS8yOTg1MDIwOTctMmFkZDJmMzYtZTc5OC00OWJiLTllOGYtNTA2ODg0MGQ2MDIyLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTIyVDA3NDcyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ3Njk0ZTNjYzk0MTIwYzFmM2ZkNmEwZDQ1Y2Q0OTFkMGE5YzUxN2NlOTk4YzRiNGI4MTZjMjA4OTZmMzBhNWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Rrx5JjLgwmGCmpxPEl00kToneUBVzSV8AP5Fp-FoZ88)
      
    ](https://private-user-images.githubusercontent.com/35952655/298502097-2add2f36-e798-49bb-9e8f-5068840d6022.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDU5MDk5NDMsIm5iZiI6MTcwNTkwOTY0MywicGF0aCI6Ii8zNTk1MjY1NS8yOTg1MDIwOTctMmFkZDJmMzYtZTc5OC00OWJiLTllOGYtNTA2ODg0MGQ2MDIyLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTIyVDA3NDcyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ3Njk0ZTNjYzk0MTIwYzFmM2ZkNmEwZDQ1Y2Q0OTFkMGE5YzUxN2NlOTk4YzRiNGI4MTZjMjA4OTZmMzBhNWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Rrx5JjLgwmGCmpxPEl00kToneUBVzSV8AP5Fp-FoZ88)
    
    
      
        
          
        
        
          
          
        
      
      [
        
          
        
      ](https://private-user-images.githubusercontent.com/35952655/298502097-2add2f36-e798-49bb-9e8f-5068840d6022.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDU5MDk5NDMsIm5iZiI6MTcwNTkwOTY0MywicGF0aCI6Ii8zNTk1MjY1NS8yOTg1MDIwOTctMmFkZDJmMzYtZTc5OC00OWJiLTllOGYtNTA2ODg0MGQ2MDIyLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTIyVDA3NDcyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ3Njk0ZTNjYzk0MTIwYzFmM2ZkNmEwZDQ1Y2Q0OTFkMGE5YzUxN2NlOTk4YzRiNGI4MTZjMjA4OTZmMzBhNWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Rrx5JjLgwmGCmpxPEl00kToneUBVzSV8AP5Fp-FoZ88)
    
   [ ![example](https://private-user-images.githubusercontent.com/35952655/298502097-2add2f36-e798-49bb-9e8f-5068840d6022.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDU5MDk5NDMsIm5iZiI6MTcwNTkwOTY0MywicGF0aCI6Ii8zNTk1MjY1NS8yOTg1MDIwOTctMmFkZDJmMzYtZTc5OC00OWJiLTllOGYtNTA2ODg0MGQ2MDIyLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTIyVDA3NDcyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ3Njk0ZTNjYzk0MTIwYzFmM2ZkNmEwZDQ1Y2Q0OTFkMGE5YzUxN2NlOTk4YzRiNGI4MTZjMjA4OTZmMzBhNWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Rrx5JjLgwmGCmpxPEl00kToneUBVzSV8AP5Fp-FoZ88) ](https://private-user-images.githubusercontent.com/35952655/298502097-2add2f36-e798-49bb-9e8f-5068840d6022.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDU5MDk5NDMsIm5iZiI6MTcwNTkwOTY0MywicGF0aCI6Ii8zNTk1MjY1NS8yOTg1MDIwOTctMmFkZDJmMzYtZTc5OC00OWJiLTllOGYtNTA2ODg0MGQ2MDIyLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTIyVDA3NDcyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ3Njk0ZTNjYzk0MTIwYzFmM2ZkNmEwZDQ1Y2Q0OTFkMGE5YzUxN2NlOTk4YzRiNGI4MTZjMjA4OTZmMzBhNWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Rrx5JjLgwmGCmpxPEl00kToneUBVzSV8AP5Fp-FoZ88)
  
    [
      
        ![example](https://private-user-images.githubusercontent.com/35952655/298502097-2add2f36-e798-49bb-9e8f-5068840d6022.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDU5MDk5NDMsIm5iZiI6MTcwNTkwOTY0MywicGF0aCI6Ii8zNTk1MjY1NS8yOTg1MDIwOTctMmFkZDJmMzYtZTc5OC00OWJiLTllOGYtNTA2ODg0MGQ2MDIyLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTIyVDA3NDcyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ3Njk0ZTNjYzk0MTIwYzFmM2ZkNmEwZDQ1Y2Q0OTFkMGE5YzUxN2NlOTk4YzRiNGI4MTZjMjA4OTZmMzBhNWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Rrx5JjLgwmGCmpxPEl00kToneUBVzSV8AP5Fp-FoZ88)
      
    ](https://private-user-images.githubusercontent.com/35952655/298502097-2add2f36-e798-49bb-9e8f-5068840d6022.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDU5MDk5NDMsIm5iZiI6MTcwNTkwOTY0MywicGF0aCI6Ii8zNTk1MjY1NS8yOTg1MDIwOTctMmFkZDJmMzYtZTc5OC00OWJiLTllOGYtNTA2ODg0MGQ2MDIyLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTIyVDA3NDcyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ3Njk0ZTNjYzk0MTIwYzFmM2ZkNmEwZDQ1Y2Q0OTFkMGE5YzUxN2NlOTk4YzRiNGI4MTZjMjA4OTZmMzBhNWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Rrx5JjLgwmGCmpxPEl00kToneUBVzSV8AP5Fp-FoZ88)
    
    
      
        
          
        
        
          
          
        
      
      [
        
          
        
      ](https://private-user-images.githubusercontent.com/35952655/298502097-2add2f36-e798-49bb-9e8f-5068840d6022.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDU5MDk5NDMsIm5iZiI6MTcwNTkwOTY0MywicGF0aCI6Ii8zNTk1MjY1NS8yOTg1MDIwOTctMmFkZDJmMzYtZTc5OC00OWJiLTllOGYtNTA2ODg0MGQ2MDIyLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTIyVDA3NDcyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ3Njk0ZTNjYzk0MTIwYzFmM2ZkNmEwZDQ1Y2Q0OTFkMGE5YzUxN2NlOTk4YzRiNGI4MTZjMjA4OTZmMzBhNWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Rrx5JjLgwmGCmpxPEl00kToneUBVzSV8AP5Fp-FoZ88)
    
   [ ](https://private-user-images.githubusercontent.com/35952655/298502097-2add2f36-e798-49bb-9e8f-5068840d6022.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDU5MDk5NDMsIm5iZiI6MTcwNTkwOTY0MywicGF0aCI6Ii8zNTk1MjY1NS8yOTg1MDIwOTctMmFkZDJmMzYtZTc5OC00OWJiLTllOGYtNTA2ODg0MGQ2MDIyLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTIyVDA3NDcyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ3Njk0ZTNjYzk0MTIwYzFmM2ZkNmEwZDQ1Y2Q0OTFkMGE5YzUxN2NlOTk4YzRiNGI4MTZjMjA4OTZmMzBhNWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Rrx5JjLgwmGCmpxPEl00kToneUBVzSV8AP5Fp-FoZ88)

Hi @CarlosRoca13 , thank you for the explanation but that isn't the point of this PR. What we want is to not automatically print the report when the picking is validated through any of it's wizards. That is due to those wizards using the base 'print_label' field and the reason I opted for adding a new field. Yo can try for yourself just validate a picking through a wizard (validate it partially for example) without the force set number of packages field and you'll end up with the report number of packages printed if the print_label field is checked.

@CarlosRoca13 @pedrobaeza could you review please?

ferran-S73 avatar May 27 '24 06:05 ferran-S73

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Sep 29 '24 12:09 github-actions[bot]

@pedrobaeza @CarlosRoca13 could you review my last comment please?

ferran-S73 avatar Oct 16 '24 11:10 ferran-S73

@rousseldenis could you remove the stale label please?

ferran-S73 avatar Oct 16 '24 13:10 ferran-S73

I'm testing what you're saying on a runbot, but I'm not getting any kind of report. I'm not sure if I'm fully understanding what you mean. If you would be so kind, could you please provide a step-by-step list of what I need to do in order for what you don't expect to happen and what you do expect to happen?

CarlosRoca13 avatar Oct 16 '24 13:10 CarlosRoca13