delivery-carrier icon indicating copy to clipboard operation
delivery-carrier copied to clipboard

[16.0][MIG] delivery_carrier_package_measure_required: Migration to 16.0

Open RodrigoBM opened this issue 1 year ago • 2 comments

issue #534

Migration from 14.0

RodrigoBM avatar Oct 03 '23 11:10 RodrigoBM

is it possible to merge this, @OCA/logistics-maintainers, thank you

RodrigoBM avatar Nov 22 '23 11:11 RodrigoBM

ping @TDu @rousseldenis @simahawk @jbaudoux @lmignon

RodrigoBM avatar Nov 22 '23 11:11 RodrigoBM

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar May 12 '24 12:05 github-actions[bot]

@OCA/logistics-maintainers Could you review for merge or apply the no stale label to this PR? Thanks!

hugosantosred avatar May 21 '24 11:05 hugosantosred

@RodrigoBM can you rebase pls?

simahawk avatar May 21 '24 11:05 simahawk

@RodrigoBM can you rebase pls?

Done @simahawk

RodrigoBM avatar May 21 '24 11:05 RodrigoBM

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar May 21 '24 13:05 OCA-git-bot

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar May 21 '24 13:05 OCA-git-bot

/ocabot migration delivery_carrier_package_measure_required

jbaudoux avatar May 21 '24 13:05 jbaudoux

ping @TDu @jbaudoux

RodrigoBM avatar May 27 '24 07:05 RodrigoBM

@RodrigoBM As a general rule, can you keep commit subject (first line) short and put description in the body (separated by a blank line from the subject).

Like:

delivery_carrier_package_measure_required: put in pack

Add measures to package when you add product to pack

jbaudoux avatar May 30 '24 07:05 jbaudoux

@RodrigoBM As a general rule, can you keep commit subject (first line) short and put description in the body (separated by a blank line from the subject).

Like:

delivery_carrier_package_measure_required: put in pack

Add measures to package when you add product to pack

Done. I will take this tip in consideration in the next contributions.

RodrigoBM avatar May 30 '24 08:05 RodrigoBM

/ocabot merge nobump

jbaudoux avatar May 30 '24 08:05 jbaudoux

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-713-by-jbaudoux-bump-nobump, awaiting test results.

OCA-git-bot avatar May 30 '24 08:05 OCA-git-bot

Congratulations, your PR was merged at fb001cb27704e25d212111410097e82464361766. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar May 30 '24 08:05 OCA-git-bot