delivery-carrier
delivery-carrier copied to clipboard
OCA
[14.0][FIX] delivery_schenker: correct float_round return
Because float_round as an example returns for 1.88 -> 1.880...01 we have to round it properly with float_repr
Closed. Duplicate of https://github.com/OCA/delivery-carrier/pull/678
The failing Tests are not related to this Change, there is as interference through an other addon
@mt-software-de Can you rebase ?
yes but this will not fix the tests. This is waiting on https://github.com/OCA/delivery-carrier/pull/786 or https://github.com/OCA/delivery-carrier/pull/643
@mt-software-de Could you adapt this part of the tests in delivery_schenker_quant_package_dimension?
Due to changing the values to be strings in this PR it fails. Just noticed it in our CI that uses this PR
@mt-software-de Could you adapt this part of the tests in
delivery_schenker_quant_package_dimension?Due to changing the values to be strings in this PR it fails. Just noticed it in our CI that uses this PR
Thx. I forgot that.
The
@mt-software-de Could you adapt this part of the tests in
delivery_schenker_quant_package_dimension?Due to changing the values to be strings in this PR it fails. Just noticed it in our CI that uses this PR
done
done
:thinking: It seems to still be failing, I think just changing the test itself in that module to compare vs strings is OK, like you did with delivery_schenker
done
🤔 It seems to still be failing, I think just changing the test itself in that module to compare vs strings is OK, like you did with delivery_schenker
now :-)
This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
