delivery-carrier
delivery-carrier copied to clipboard
[16.0][ADD] sale_order_wh_from_delivery_carrier
This module allows to set warehouse in Sales Order based on selected shipping method.
This PR has the approved
label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
Hey @OCA/logistics-maintainers could you please have a look at this?
@geomer198 Thanks for this. I would say I'd prefer explicit words in modules names as they can quickly seems like module x_y_z which does not mean anything.
@geomer198 Thanks for this. I would say I'd prefer explicit words in modules names as they can quickly seems like module x_y_z which does not mean anything.
Thank you for the feedback. Any ideas how this module name should look like?
@rousseldenis Could you please check my changes?
@rousseldenis Could you check changes?
This PR has the approved
label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
This PR has the approved
label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
@geomer198 Thanks for this. I would say I'd prefer explicit words in modules names as they can quickly seems like module x_y_z which does not mean anything.
Thank you for the feedback. Any ideas how this module name should look like?
sale_order_warehouse_from_delivery_carrier
@geomer198 Thanks for this. I would say I'd prefer explicit words in modules names as they can quickly seems like module x_y_z which does not mean anything.
Thank you for the feedback. Any ideas how this module name should look like?
sale_order_warehouse_from_delivery_carrier
Module is renamed. Could you check changes?
@rousseldenis, @jbaudoux Could you check again?
@rousseldenis, @jbaudoux Could you check again?
Thanks.
/ocabot merge nobump
On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-684-by-jbaudoux-bump-nobump, awaiting test results.
@jbaudoux The merge process could not be finalized, because command twine check odoo_addon_sale_order_warehouse_from_delivery_carrier-16.0.1.0.0.3-py3-none-any.whl
failed with output:
Checking
odoo_addon_sale_order_warehouse_from_delivery_carrier-16.0.1.0.0.3-py3-none-any.
whl: [31mFAILED[0m
[31mERROR [0m `long_description` has syntax errors in markup and would not be
rendered on PyPI.
No content rendered from RST source.
[33mWARNING [0m `long_description_content_type` missing. defaulting to `text/x-rst`.
This PR has the approved
label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
@geomer198 can you squash the commits?
This PR has the approved
label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
/ocabot merge nobump
This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-684-by-jbaudoux-bump-nobump, awaiting test results.
Congratulations, your PR was merged at 6d9ecd05dc5b0b263c272f61da0be29c7759322d. Thanks a lot for contributing to OCA. ❤️