delivery-carrier icon indicating copy to clipboard operation
delivery-carrier copied to clipboard

[16.0][ADD] sale_order_wh_from_delivery_carrier

Open geomer198 opened this issue 1 year ago • 9 comments

This module allows to set warehouse in Sales Order based on selected shipping method.

geomer198 avatar Aug 06 '23 19:08 geomer198

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Aug 30 '23 21:08 OCA-git-bot

Hey @OCA/logistics-maintainers could you please have a look at this?

ivs-cetmix avatar Oct 13 '23 10:10 ivs-cetmix

@geomer198 Thanks for this. I would say I'd prefer explicit words in modules names as they can quickly seems like module x_y_z which does not mean anything.

rousseldenis avatar Oct 13 '23 11:10 rousseldenis

@geomer198 Thanks for this. I would say I'd prefer explicit words in modules names as they can quickly seems like module x_y_z which does not mean anything.

Thank you for the feedback. Any ideas how this module name should look like?

ivs-cetmix avatar Oct 13 '23 11:10 ivs-cetmix

@rousseldenis Could you please check my changes?

geomer198 avatar Nov 19 '23 13:11 geomer198

@rousseldenis Could you check changes?

geomer198 avatar Feb 21 '24 12:02 geomer198

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Feb 21 '24 13:02 OCA-git-bot

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Feb 21 '24 13:02 OCA-git-bot

@geomer198 Thanks for this. I would say I'd prefer explicit words in modules names as they can quickly seems like module x_y_z which does not mean anything.

Thank you for the feedback. Any ideas how this module name should look like?

sale_order_warehouse_from_delivery_carrier

rousseldenis avatar Feb 21 '24 13:02 rousseldenis

@geomer198 Thanks for this. I would say I'd prefer explicit words in modules names as they can quickly seems like module x_y_z which does not mean anything.

Thank you for the feedback. Any ideas how this module name should look like?

sale_order_warehouse_from_delivery_carrier

Module is renamed. Could you check changes?

geomer198 avatar Jul 23 '24 21:07 geomer198

@rousseldenis, @jbaudoux Could you check again?

geomer198 avatar Jul 24 '24 09:07 geomer198

@rousseldenis, @jbaudoux Could you check again?

Thanks.

/ocabot merge nobump

jbaudoux avatar Jul 24 '24 14:07 jbaudoux

On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-684-by-jbaudoux-bump-nobump, awaiting test results.

OCA-git-bot avatar Jul 24 '24 14:07 OCA-git-bot

@jbaudoux The merge process could not be finalized, because command twine check odoo_addon_sale_order_warehouse_from_delivery_carrier-16.0.1.0.0.3-py3-none-any.whl failed with output:

Checking 
odoo_addon_sale_order_warehouse_from_delivery_carrier-16.0.1.0.0.3-py3-none-any.
whl: [31mFAILED[0m
[31mERROR   [0m `long_description` has syntax errors in markup and would not be        
         rendered on PyPI.                                                      
         No content rendered from RST source.                                   
[33mWARNING [0m `long_description_content_type` missing. defaulting to `text/x-rst`.   

OCA-git-bot avatar Jul 24 '24 14:07 OCA-git-bot

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Jul 24 '24 14:07 OCA-git-bot

@geomer198 can you squash the commits?

jbaudoux avatar Jul 25 '24 12:07 jbaudoux

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Jul 25 '24 13:07 OCA-git-bot

/ocabot merge nobump

jbaudoux avatar Jul 25 '24 13:07 jbaudoux

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-684-by-jbaudoux-bump-nobump, awaiting test results.

OCA-git-bot avatar Jul 25 '24 13:07 OCA-git-bot

Congratulations, your PR was merged at 6d9ecd05dc5b0b263c272f61da0be29c7759322d. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Jul 25 '24 13:07 OCA-git-bot