ddmrp icon indicating copy to clipboard operation
ddmrp copied to clipboard

[14.0][IMP] ddmrp: Change Manufacturing Orders smart button in buffer

Open BernatPForgeFlow opened this issue 1 year ago • 4 comments

Before: Open only MO procured from the specific buffer. Now: Open all MO with the same product and warehouse than the buffer.

BernatPForgeFlow avatar Aug 03 '23 07:08 BernatPForgeFlow

Hi @JordiBForgeFlow, @LoisRForgeFlow, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Aug 03 '23 07:08 OCA-git-bot

I think this fix could be even better with the following changes:

* Try to assign a buffer to new MOs automatically even if not created from a stock buffer, as it happens with PO lines already.

* Warehouse is a bit too wide as the domain to find a proper buffer. I would use the finished good location of the MO and check that it is child of the location of the candidate buffer.

* A migration script can be added to try to apply buffer to already existing MOs (maybe only MOs in progress to be a bit conservative?)

@LoisRForgeFlow I like the requested changes and think they are a good improvement.

I just don't see point two though. I think that sometimes the finished good location of the MO is not a sublocation of the buffer. So it wouldn't end up finding which buffer it is. On that, maybe I could add filter by levels on which:

  1. Firstly I search by finished good location of the MO
  2. If it didn't find a buffer, search by the entire warehouse.
  3. And if neither of both find a buffer, then do not assign any buffer to the MO.

What do you think?

BernatPForgeFlow avatar Aug 07 '23 11:08 BernatPForgeFlow

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Mar 17 '24 12:03 github-actions[bot]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Sep 08 '24 12:09 github-actions[bot]