OCA
[18.0][IMP] crm_phonecall: Add computed partner city/state/zip fields
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@HaraldPanten or @rafaelbn whenever you have time, could you please review and merge this PR? Thanks
@HaraldPanten The merge process could not start, because command `git merge --no-ff -m 'Merge PR #663 into 18.0
Signed-off-by HaraldPanten' tmp-pr-663` failed with output:
Auto-merging crm_phonecall/i18n/es.po
CONFLICT (content): Merge conflict in crm_phonecall/i18n/es.po
Automatic merge failed; fix conflicts and then commit the result.
@HaraldPanten The conflict has been resolved. Could you please try merging again? Thanks
On my way to merge this fine PR! Prepared branch 18.0-ocabot-merge-pr-663-by-HaraldPanten-bump-patch, awaiting test results.
Congratulations, your PR was merged at dbfaa59a1377f02845d710c260bb298a051f3c40. Thanks a lot for contributing to OCA. ❤️
@Anxo82 @HaraldPanten @ValentinVinagre this is provoking a collapse on existing databases, as the new fields, being stored, are computed on module update, and on big DBs, this takes a lot. This kind of changes should be accompanied of pre-init/post-init hooks, and a migration script.
I'm reverting this PR in #715, as it's very harmful, provoking the effects commented, but also not seeing the value of incrementing the size of the DB for storing data that is very easily obtained for example with a SQL view and add a pivot view with that "report", or Odoo has the option for a partner to show in the widget directly the address. We can discuss the goal of these changes and select the best option in a new PR.