crm icon indicating copy to clipboard operation
crm copied to clipboard

[16.0][MIG] marketing_crm_partner

Open yibudak opened this issue 1 year ago • 5 comments

yibudak avatar Jan 26 '24 08:01 yibudak

@pedrobaeza @CarlosRoca13 @stefan-tecnativa

yibudak avatar Jan 26 '24 08:01 yibudak

Please fixup the 3 migration commits into this one: @yibudak [MIG] marketing_crm_partner: Migration to 16.0

CarlosRoca13 avatar Mar 27 '24 06:03 CarlosRoca13

@chienandalu @CarlosRoca13

yibudak avatar Apr 19 '24 06:04 yibudak

Tests are red :confused:

CarlosRoca13 avatar Apr 19 '24 06:04 CarlosRoca13

Tests are red 😕

https://github.com/OCA/crm/actions/runs/8749403166/job/24011007372?pr=543#step:8:336

Could you tell me how can I fix that? Thanks.

yibudak avatar Apr 19 '24 06:04 yibudak

Maybe just rebase to the newest main branch head as the error comes from another module...

chienandalu avatar May 20 '24 08:05 chienandalu

@chienandalu exactly! now, all the checks are passed

yibudak avatar May 20 '24 13:05 yibudak

You have to do a rebase, not a pull. Please amend it.

pedrobaeza avatar May 20 '24 15:05 pedrobaeza

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar May 20 '24 16:05 OCA-git-bot

@pedrobaeza Is it okay now?

yibudak avatar May 29 '24 11:05 yibudak

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-543-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot avatar May 29 '24 18:05 OCA-git-bot

Congratulations, your PR was merged at 23f01136c8b8eff18be64bcdeb6bc72b8450c397. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar May 29 '24 18:05 OCA-git-bot