crm icon indicating copy to clipboard operation
crm copied to clipboard

[17.0][MIG] crm_phonecall: Migration to 17.0

Open peluko00 opened this issue 2 years ago • 2 comments

Module migrated to version 17.0

cc https://github.com/APSL 149031

@miquelalzanillas @lbarry-apsl @javierobcn @mpascuall please review

Issue https://github.com/OCA/crm/issues/525

peluko00 avatar Dec 01 '23 07:12 peluko00

Now you get it! Please check the rest of your pull requests with the same problem. Another thing: you don't need to close existing pull request. Just fix it locally with the same branch name, and then forced push the result to your remote.

/ocabot migration crm_phonecall

pedrobaeza avatar Dec 01 '23 07:12 pedrobaeza

Now you get it! Please check the rest of your pull requests with the same problem. Another thing: you don't need to close existing pull request. Just fix it locally with the same branch name, and then forced push the result to your remote.

/ocabot migration crm_phonecall

OK! Sorry for the mistakes

peluko00 avatar Dec 01 '23 07:12 peluko00

I was hoping to see the categories in the logged calls, it could be an improvement.

lbarry-apsl avatar May 15 '24 10:05 lbarry-apsl

Hi could you please rebase and squash administrative commits? Thanks!

Hi could you please rebase and squash administrative commits? Thanks!

Done! Ready for review

peluko00 avatar Jul 08 '24 07:07 peluko00

There are still a lot of commits which should be squashed. Here some examples, but there are a lot more:

image https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

CRogos avatar Jul 08 '24 09:07 CRogos

This PR looks fantastic, let's merge it! Prepared branch 17.0-ocabot-merge-pr-540-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot avatar Jul 11 '24 18:07 OCA-git-bot

Congratulations, your PR was merged at 0f2e729514d1f14b58498cb15fa6bea897af9b02. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Jul 11 '24 18:07 OCA-git-bot