contract icon indicating copy to clipboard operation
contract copied to clipboard

Published 20 hours ago • verified publisher icon OCA

[14.0][FIX] contract/contract_sale_generation: Compute correctly the recurring next date after stop()

Open rousseldenis opened this issue 3 years ago • 7 comments

rousseldenis avatar Jun 16 '22 14:06 rousseldenis

I think this is fixed in a simpler way in https://github.com/OCA/contract/pull/853

pedrobaeza avatar Jul 01 '22 18:07 pedrobaeza

I think this is fixed in a simpler way in #853

That is certainly one piece.

But this is a particular case.

rousseldenis avatar Jul 04 '22 06:07 rousseldenis

I think reverting part of the 14.0 changes and applying the fix will fix it. Please check #854 for that .

pedrobaeza avatar Jul 04 '22 09:07 pedrobaeza

@CRogos @pedrobaeza this one runs in production for weeks. So, IMHO we can reasonably merge it

rousseldenis avatar Sep 15 '22 09:09 rousseldenis

#854 is more suitable and align the versions. If anything non covered, please indicate and I'll fix it.

pedrobaeza avatar Sep 15 '22 09:09 pedrobaeza

@rousseldenis this PR is a huge improvement in the behavior regarding the next invoice date. Thanks a lot!

I just found one little issue when creating a contract with "Recurrence at line level?" in the past (ending before today). Than the "Generate Recurring Invoices from Contract" Server Action is not creating a invoice. Using the "Create Invoice" button is working. image

CRogos avatar Sep 15 '22 09:09 CRogos

@victoralmau could you review this commit?

CRogos avatar Oct 05 '22 15:10 CRogos