contract icon indicating copy to clipboard operation
contract copied to clipboard

[18.0] [MIG] contract_sale_mandate

Open samirGuesmi opened this issue 7 months ago • 3 comments

samirGuesmi avatar May 28 '25 14:05 samirGuesmi

/ocabot migration contract_sale_mandate

rousseldenis avatar Jun 10 '25 08:06 rousseldenis

@samirGuesmi Be careful, you mixed other changes in your commit for test-requirements.txt :

image

rousseldenis avatar Jun 10 '25 08:06 rousseldenis

To help reviewers, it is better to put links to depending PRs in this description.

rousseldenis avatar Jun 10 '25 08:06 rousseldenis

One dependency to be merged to go. (added the list to the description)

yvaucher avatar Jul 29 '25 17:07 yvaucher

@samirGuesmi The last dependency has been merged, let's finish this work today :muscle:

qgroulard avatar Sep 17 '25 09:09 qgroulard

Thanks all, here we are.

samirGuesmi avatar Sep 17 '25 10:09 samirGuesmi

There is still one issue with the tests:

odoo.addons.contract_sale_mandate.tests.test_contract_sale_mandate: FAIL: TestContractSaleMandate.test_01
Traceback (most recent call last):
  File "/__w/contract/contract/contract_sale_mandate/tests/test_contract_sale_mandate.py", line 61, in test_01
    self.assertEqual(contracts[0].mandate_id, self.mandate)
AssertionError: account.banking.mandate() != account.banking.mandate(3,)

yvaucher avatar Sep 17 '25 10:09 yvaucher

@yvaucher Done

samirGuesmi avatar Sep 17 '25 11:09 samirGuesmi

@rousseldenis Could you please update your review ?

qgroulard avatar Sep 17 '25 12:09 qgroulard

/ocabot merge nobump

yvaucher avatar Sep 17 '25 12:09 yvaucher

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 18.0-ocabot-merge-pr-1246-by-yvaucher-bump-nobump, awaiting test results.

OCA-git-bot avatar Sep 17 '25 12:09 OCA-git-bot

Congratulations, your PR was merged at 637116bf3005c697f5ed7f21fc4ba86720542859. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Sep 17 '25 12:09 OCA-git-bot