OCA
[18.0][MIG] contract_price_revision
Thanks for your contribution @AlvRM2002 , remember to check the migration guidelines and do it step by step. Missing the pre-commit stuff right now.
@AlvRM2002 I can do a code review after you get tests in green.
What is required to get the tests green? It appears this PR is stuck waiting for the contract module to be updated to v18.
@AlvRM2002 I can do a code review after you get tests in green.
What is required to get the tests green? It appears this PR is stuck waiting for the contract module to be updated to v18.
@AlvRM2002 @AdamBark In order to test this in runboat and make tests green, you need to follow this : https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29
@AlvRM2002 I can do a code review after you get tests in green.
What is required to get the tests green? It appears this PR is stuck waiting for the contract module to be updated to v18.
@AdamBark you can now try it with the runbot, thanks for your interest!
@AlvaroRM11 Thanks for this.
Could you put depending PR's link in this description in order to easy review? Thanks
@AlvaroRM11 Thanks for this.
Could you put depending PR's link in this description in order to easy review? Thanks
Done!
@AlvaroRM11 To get green tests, you should include contract_line_successor PR in test-requirements.txt too
This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
