contract icon indicating copy to clipboard operation
contract copied to clipboard

[18.0][MIG] contract_sale

Open sbejaoui opened this issue 1 year ago • 8 comments

sbejaoui avatar Nov 04 '24 14:11 sbejaoui

@sbejaoui are you still working on this PR?

MohamedOsman7 avatar Apr 17 '25 08:04 MohamedOsman7

@sbejaoui are you still working on this PR?

Yes, I am finishing the refactoring of the contract module (!1136), and then I will rebase this PR. I am not planning to do any extra work on it, so you can use it as it is now if you need. All the 18.0 migration PRs will be merged soon, I hope.

sbejaoui avatar Apr 17 '25 08:04 sbejaoui

/ocabot migration contract_sale

sbejaoui avatar Apr 21 '25 14:04 sbejaoui

@sbejaoui Could you attend comments ?

rousseldenis avatar Jun 10 '25 07:06 rousseldenis

@sbejaoui Could you attend comments ?

yes

sbejaoui avatar Jun 19 '25 07:06 sbejaoui

done

sbejaoui avatar Jun 19 '25 07:06 sbejaoui

@pedrobaeza could you merge?

CRogos avatar Jun 20 '25 10:06 CRogos

@acsonefho should check and remove his requested changes

pedrobaeza avatar Jun 20 '25 14:06 pedrobaeza

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Jul 07 '25 06:07 OCA-git-bot

@pedrobaeza could you merge?

CRogos avatar Jul 14 '25 13:07 CRogos

/ocabot merge nobump

pedrobaeza avatar Jul 14 '25 13:07 pedrobaeza

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 18.0-ocabot-merge-pr-1138-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot avatar Jul 14 '25 14:07 OCA-git-bot

Congratulations, your PR was merged at b74b18e62eaf406c5082cc81bbf1ee5c16502eb3. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Jul 14 '25 14:07 OCA-git-bot