contract icon indicating copy to clipboard operation
contract copied to clipboard

[17.0][FIX] contract: report translations & change structure

Open peluko00 opened this issue 1 year ago • 1 comments

Description of the problem: Go to Invoicing -> Customer Contracts and try to print a contract. Normally when you print a contract the default language of that one bases on customer language but not works in that report. Example: Your default language is Spanish and your customer's default language is English Try to print the report and you see that the report prints in Spanish and not in English. I changed the structure because i'm base of the report of an invoice from the odoo's core structure(see more in the links below):

https://github.com/odoo/odoo/blob/17.0/addons/account/views/report_invoice.xml#L429 https://github.com/odoo/odoo/blob/17.0/addons/account/views/report_invoice.xml#L4

I test that structure first and works perfect and I try to reproduce in that case and works fine.

contract_report_failed.webm

contract_report_works.webm

peluko00 avatar Apr 23 '24 09:04 peluko00

Fixed Module report

cc https://github.com/APSL 154355

@miquelalzanillas @lbarry-apsl @javierobcn @mpascuall please review

peluko00 avatar Apr 23 '24 09:04 peluko00

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Aug 25 '24 12:08 github-actions[bot]

Any update @pedrobaeza for this fix?

peluko00 avatar Aug 26 '24 05:08 peluko00

This PR looks fantastic, let's merge it! Prepared branch 17.0-ocabot-merge-pr-1079-by-pedrobaeza-bump-minor, awaiting test results.

OCA-git-bot avatar Aug 26 '24 06:08 OCA-git-bot

Congratulations, your PR was merged at 6506320f1c0f7843d209e89f4e7d4cf66686e749. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Aug 26 '24 06:08 OCA-git-bot