[16.0] Bugs and improvements in subscription_oca

[tarteo]

Just wanted to check before I create a PR if some of these are as intended.

https://github.com/OCA/contract/blob/6c900c92cf172678bd87f1dcfe626f492b3ca6b6/subscription_oca/models/sale_subscription.py#L154

This will not actually close the subscription just open the close reason wizard.

https://github.com/OCA/contract/blob/6c900c92cf172678bd87f1dcfe626f492b3ca6b6/subscription_oca/wizard/close_subscription_wizard.py#L25

Why do we archive the record here directly IMO closed subscription should be just in the closed stage not archived directly

https://github.com/OCA/contract/blob/6c900c92cf172678bd87f1dcfe626f492b3ca6b6/subscription_oca/models/sale_subscription_stage.py#L15

This field is redundant because of field type.

https://github.com/OCA/contract/blob/6c900c92cf172678bd87f1dcfe626f492b3ca6b6/subscription_oca/models/sale_subscription.py#L156-L160

This way we can't have "draft" subscriptions. There should by another stage before "pre".

https://github.com/OCA/contract/blob/6c900c92cf172678bd87f1dcfe626f492b3ca6b6/subscription_oca/models/sale_subscription.py#L145

If the cron job fails for a day subscription begin to stagnate, this should be <=

https://github.com/OCA/contract/blob/18d62d365201bbba5f1633411081cb07a3bea9b7/subscription_oca/models/sale_subscription.py#L189

This should be the otherway around if there is not a boundary (unlimited) this should be False not True. This is confusing.

Other:

• The tests don't pass if sale_timesheet is installed.
• Showing the billing period on the invoice would be nice.

[francesco-ooops]

Hi @tarteo , I would suggest checking also all the IMPs and FIXs made to the v14 of the module: https://github.com/OCA/contract/pulls?q=is%3Apr+is%3Aclosed+subscription_oca

[gregory-moka]

Hello I add 1 more lack in the addon : On sale order, we are not able to define the subscription's start date. Maybe we can detect if a product is a subscription product to display the start date field (by default, this start date is defined by confirmation date).

Another issue is linked to the access rules. For non-admin users, it's not possible to access to contact models once the addon is installed.

[tarteo]

A sequence field on sale.subscription.line can also be useful

[github-actions[bot]]

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.