contract icon indicating copy to clipboard operation
contract copied to clipboard

[IMP] contract: Allow to single invoice a contract by users

Open etobella opened this issue 2 years ago • 13 comments

It should allow you to process sale orders and other kinds, as it is using the cron function

@dixmit

etobella avatar Oct 11 '23 09:10 etobella

Why this? You already have the button to manually invoice it on the contract itsel.

pedrobaeza avatar Oct 11 '23 11:10 pedrobaeza

That button is only accessible on debug mode, and it does not verify dates, so, If I push the button three times It will create the invoice three times.

Wit my new way an standard user can create the invoices without worrying if he/she is doing something wrong

etobella avatar Oct 11 '23 11:10 etobella

Then I think it's better to fine tune that button, showing it to billing users, and showing the popup to decide if force or not to make the invoice.

pedrobaeza avatar Oct 11 '23 11:10 pedrobaeza

So, should I keep my button and remove the old one?

etobella avatar Oct 11 '23 13:10 etobella

I think it should be only one button to do both things according a check saying to force or not.

pedrobaeza avatar Oct 12 '23 10:10 pedrobaeza

functionnal test OK

damdam-s avatar Nov 03 '23 14:11 damdam-s

any issue w/ this one?

damdam-s avatar Feb 19 '24 10:02 damdam-s

Just waiting for approvals

etobella avatar Feb 19 '24 10:02 etobella

ok thanks @etobella FYI i'm currently working on a refactor for the cron to use the "wizard" method to have the same behaviour from the cron and from the wizard. Any objection?

damdam-s avatar Feb 19 '24 10:02 damdam-s

good for me

etobella avatar Feb 19 '24 11:02 etobella

@etobella here is the PR against this PR https://github.com/dixmit/contract/pull/2

damdam-s avatar Feb 19 '24 16:02 damdam-s

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Jun 23 '24 12:06 github-actions[bot]

@pedrobaeza I think the changes fits your requests :smile:

etobella avatar Jul 28 '24 15:07 etobella

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Dec 08 '24 12:12 github-actions[bot]