connector
connector copied to clipboard
OCA
[15.0][MIG] connector_base_product: Migration to 15.0
Dependency below, please review
https://github.com/OCA/sale-workflow/pull/2005 https://github.com/OCA/connector-prestashop/pull/151 https://github.com/OCA/connector-ecommerce/pull/70 https://github.com/OCA/server-tools/pull/2334 https://github.com/OCA/product-attribute/pull/1070 https://github.com/OCA/product-attribute/pull/1069
I can't solve the runboat error. Can someone give me a clue /cc @guewen
Finally, after accepting other dependent PRs, they have passed the tests
What is missing here?
Is needed two reviewers and one PSC can accept the PR
Hello @flachica I have no problem with your change and I believe it is correct. However, the checks won't pass because the CI metafiles are not up to date in this v15 connector repo. The runbot is decommissioned and replaced by runboat. Somebody should remove the .travis.yml and add a github action folder like .github/workflows all metafiles can be seen in https://github.com/OCA/maintainer-quality-tools
Once a PR is made to fix these metafiles, I would say you could rebase your PR and if checks pass it will have more chances to be merged (I would approve it at least).
Hello @flachica I have no problem with your change and I believe it is correct. However, the checks won't pass because the CI metafiles are not up to date in this v15 connector repo. The runbot is decommissioned and replaced by runboat. Somebody should remove the .travis.yml and add a github action folder like .github/workflows all metafiles can be seen in https://github.com/OCA/maintainer-quality-tools
Once a PR is made to fix these metafiles, I would say you could rebase your PR and if checks pass it will have more chances to be merged (I would approve it at least).
All done! Thanks for your review @rvalyi
commits are messed up, please rebase and keep the mig changes in the last one, thanks!
commits are messed up, please rebase and keep the mig changes in the last one, thanks!
Rebase done, thanks!
the 1st commit is still wrong. Contains migration changes https://github.com/OCA/connector/pull/428/commits/1e5d87fc5dba1d293ffb4b638bb095c44d8a1cc2 I'd rollback the 2 commits and stage only what's needed manually.
I migrated the module step by step. Forced push the changes. Can review, please @simahawk
@flachica better now. Can you rewrite the commit msg to connector_base_product: Migration to 15.0? Thanks!
@flachica better now. Can you rewrite the commit msg to
connector_base_product: Migration to 15.0? Thanks!
Done
"Migration to 15.0" of what? As per guidelines and per my msg above, pls include the module name :pray:
"Migration to 15.0" of what? As per guidelines and per my msg above, pls include the module name pray
Re done
Search for "OCA migration guidelines" and you should land on these pages
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0 https://github.com/OCA/maintainer-tools/wiki#migration https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst
In order to finish migrating the Prestashop connector I need this PR to be merged. It has one approval. Any PSC check it out? /cc @simahawk @gurneyalex
Good job @flachica ! Hopefully it will soon be revised and can be merged
Hi @asierneiradev. To be merged this PR needs one more review. Please, click on Files changed and submit your review
This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
Dependency below, please review
OCA/sale-workflow#2005 OCA/connector-prestashop#151 OCA/connector-ecommerce#70 OCA/server-tools#2334 OCA/product-attribute#1070 OCA/product-attribute#1069
@flachica please do not mention all these PRs in all PRs as "dependencies". They are "related" but they do not depend on each other.
If you do so, ppl will expect to review those PRs first to unlock this one. Or, like in my case, I will not merge at first because I'll see those pending links and I'll have to spend some time understanding that they are actually not blocking at all. Please, clean them up or make these references more clear.
Thanks for your understanding!
Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 15.0-ocabot-merge-pr-428-by-simahawk-bump-nobump, awaiting test results.
@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-428-by-simahawk-bump-nobump.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-428-by-simahawk-bump-nobump.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
we need this https://github.com/OCA/connector/pull/455