connector-interfaces icon indicating copy to clipboard operation
connector-interfaces copied to clipboard

[MIG] connector_importer_source_sftp: Migration to 16.0

Open p-tombez opened this issue 1 year ago • 4 comments

ref: BSALLO-1566

p-tombez avatar Aug 29 '24 09:08 p-tombez

FTR I couldn't replicate the failing test on the event listener locally

2024-09-04 05:27:22,457 260 ERROR odoo odoo.tests.suite: ERROR: setUpClass (odoo.addons.connector_importer_source_sftp.tests.test_event_listener.TestRecordImporterFinishedEvent)
Traceback (most recent call last):
  File "/__w/connector-interfaces/connector-interfaces/connector_importer_source_sftp/tests/test_event_listener.py", line 25, in setUpClass
    cls.recordset.write(
  File "/opt/odoo-venv/lib/python3.10/site-packages/odoo/addons/component_event/models/base.py", line 109, in write
    result = super(Base, self).write(vals)
  File "/opt/odoo/odoo/models.py", line 3784, in write
    field.write(self, value)
  File "/opt/odoo/odoo/fields.py", line 1125, in write
    cache_value = self.convert_to_cache(value, records)
  File "/opt/odoo/odoo/fields.py", line 2735, in convert_to_cache
    raise ValueError("Wrong value for %s: %r" % (self, value))
ValueError: Wrong value for import.recordset.source_model: 'import.source.csv.sftp'

Looks weird because the selection option should be already there.

simahawk avatar Sep 04 '24 05:09 simahawk

Ok. it fails only if you run tests at db creation.

simahawk avatar Sep 04 '24 05:09 simahawk

Great, this change https://github.com/OCA/connector-interfaces/pull/138/commits/876c6097e3790956e5bdc88b11757d4fb5f6c6b1 fixed tests locally but not here :sweat:

simahawk avatar Sep 04 '24 05:09 simahawk

I added a PR to update the dependency: https://github.com/p-tombez/connector-interfaces/pull/1

leemannd avatar Sep 06 '24 12:09 leemannd

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Jan 12 '25 12:01 github-actions[bot]