community-data-files icon indicating copy to clipboard operation
community-data-files copied to clipboard

[17.0] [MIG] l10n_eu_product_adr_dangerous_goods: migration to v17

Open rrebollo opened this issue 9 months ago • 5 comments

Although commit history comes from v14 is really a backport from v18 merged addon.

#177 @BinhexTeam

rrebollo avatar Mar 15 '25 11:03 rrebollo

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Jul 13 '25 12:07 github-actions[bot]

@pedrobaeza now that #231 is merged, could you reopen this? I’ll handle the remaining work to get it done.

rrebollo avatar Sep 01 '25 18:09 rrebollo

@pedrobaeza wouldn’t it be better to remove the stale label as well, please?

rrebollo avatar Sep 01 '25 19:09 rrebollo

Tested on Odoo 17 CE — installs fine, “Is Dangerous” checkbox and Dangerous Goods tab work as expected. Only concern is the UX could be more friendly. When “Is Dangerous” is checked but no Dangerous Good name is entered, the error could be more specific or auto-open the Dangerous Goods tab.

AnsarLatif avatar Sep 07 '25 05:09 AnsarLatif

@AnsarLatif, thank you for pointing this out. To clarify for everyone, the components you mentioned are part of the l10n_eu_product_adr module's architecture. This addon relies on them but does not define them directly.

rrebollo avatar Sep 30 '25 22:09 rrebollo