community-data-files
community-data-files copied to clipboard
OCA
Migration to version 18.0
Todo
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0
Modules to migrate
- [ ] account_payment_unece
- [ ] account_tax_unece
- [x] base_bank_from_iban - By @mpascuall - #228
- [ ] base_currency_iso_4217
- [x] base_iso3166 - By @ClemRiviere - #220
- [x] base_unece - By @LucasTran380381 - #216
- [x] company_sanitary_registry - By @eduezerouali-tecnativa - #242
- [x] l10n_eu_nace - By @BertVGroenendael - #229
- [x] l10n_eu_product_adr - By @chaule97 - #208
- [x] l10n_eu_product_adr_dangerous_goods - By @xaviedoanhduy - #211
- [x] product_fao_fishing - By @CarlosRoca13 - #230
- [ ] uom_unece
Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list
l10n_eu_product_adr_dangerous_goods: https://github.com/OCA/community-data-files/pull/211
account_tax_unece https://github.com/OCA/community-data-files/pull/215
I was wondering if it's a good idea to continue to maintain uom_unece in Odoo because, since v17, the account module has a method _get_unece_code() on uom.uom, cf https://github.com/odoo/odoo/blob/18.0/addons/account/models/uom_uom.py#L17 (this method was part of account_edi from v14 to v16).
This method works to get the UNECE code from an uom. First drawback: when you manually add a unit of measure in Odoo, you have to inherit the method _get_unece_code() to set the corresponding UNECE code. But, for me, the major drawback of adopting the code in the account module is that, when you import an order/invoice, you need to find the uom from the UNECE code, and I don't see how you can do that with the code of the account module (without writing horrible code that loops to every uom to get the corresponding UNECE code and then match... too dirty).
So my conclusion is that we should continue to use uom_unece. Do you have the same opinion ?
