OCA
[16.0[IMP]account_commission: add payment date limit on settle commissions
Hi @pedrobaeza, some modules you are maintaining are being modified, check this out!
Please use with_context decorator instead of a hard replacement of this type, as it's not guaranteed that the internal implementation will work with this kind of operations.
@pedrobaeza
Shouldn't we prefer this approach instead of with_context? The old context would be discarded entirely
No, with_context can have an entire dict as argument or just a context key. Depending on which you select, you will have a replacement or just a new/edited key.
This is adding a bit of complication on the module for a specific case, but it's not too much overhead and it's tested, so let's continue.
/ocabot merge minor
What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-588-by-pedrobaeza-bump-minor, awaiting test results.
Congratulations, your PR was merged at de7708ef3d3b2a1f9876092063c10d75c9949bcc. Thanks a lot for contributing to OCA. ❤️