commission icon indicating copy to clipboard operation
commission copied to clipboard

[17.0][IMP] commission: Add new settlement period (All pending records) to settle in only one settlement

Open sergio-teruel opened this issue 1 year ago • 7 comments

Missing commit https://github.com/OCA/commission/pull/519/commits/10517822e6011212c2e151a6d32b4e09ee1144d0 from 15.0

cc @Tecnativa

ping @victoralmau @CarlosRoca13

sergio-teruel avatar May 20 '24 09:05 sergio-teruel

Hi @pedrobaeza, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar May 20 '24 09:05 OCA-git-bot

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Sep 22 '24 12:09 github-actions[bot]

@sergio-teruel please fix the fw-port for merging it.

pedrobaeza avatar Sep 23 '24 18:09 pedrobaeza

Not enough yet

pedrobaeza avatar Sep 26 '24 09:09 pedrobaeza

the repo is weird

sergio-teruel avatar Sep 26 '24 09:09 sergio-teruel

Well, the error seems clear that has to do with how to do a refund:

2024-09-26 09:06:27,009 244 INFO odoo odoo.addons.sale_commission.tests.test_sale_commission: Starting TestSaleCommission.test_invoice_full_refund ... 
2024-09-26 09:06:27,342 244 INFO odoo odoo.addons.sale_commission.tests.test_sale_commission: ====================================================================== 
2024-09-26 09:06:27,342 244 ERROR odoo odoo.addons.sale_commission.tests.test_sale_commission: FAIL: TestSaleCommission.test_invoice_full_refund
Traceback (most recent call last):
  File "/__w/commission/commission/account_commission/tests/test_account_commission.py", line 610, in test_invoice_full_refund
    self.assertEqual(2, len(settlements.line_ids))
AssertionError: 2 != 0

pedrobaeza avatar Sep 26 '24 09:09 pedrobaeza

Thera is a lot of commits from v16 missed

sergio-teruel avatar Sep 26 '24 09:09 sergio-teruel

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Jan 26 '25 12:01 github-actions[bot]