commission icon indicating copy to clipboard operation
commission copied to clipboard

[ADD] sale_commission_product_criteria_triple_discount

Open SirAionTech opened this issue 1 year ago • 1 comments

Depends on:

  • [x] https://github.com/OCA/commission/pull/466

SirAionTech avatar Apr 04 '24 08:04 SirAionTech

Tests of sale_commission_product_criteria are failing with error

2024-04-04 08:24:47,763 463 ERROR odoo odoo.addons.sale_commission_product_criteria.tests.test_sale_commission_product_criteria: FAIL: TestSaleCommission.test_sale_commission_product_criteria_items Traceback (most recent call last): File "/__w/commission/commission/sale_commission_product_criteria/tests/test_sale_commission_product_criteria.py", line 80, in test_sale_commission_product_criteria_items self.assertEqual(so_1.order_line.agent_ids.amount, 10) AssertionError: 15.0 != 10

because the matched commission item is sale_commission_product_criteria_discount.demo_commission_rules_item_disc_2 instead of sale_commission_product_criteria.demo_commission_rules_item_1, this happens in https://github.com/OCA/commission/blob/35a4363d6178a2b6ee0002556e9b4f1fc9e8abbc/sale_commission_product_criteria/models/sale_commission_line_mixin.py#L62. It is something similar to what already described in https://github.com/OCA/commission/pull/467. I don't exactly understand why it is failing (and how it is working in 14.0), will investigate further when the dependency is merged.

SirAionTech avatar Apr 04 '24 09:04 SirAionTech

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Oct 13 '24 12:10 github-actions[bot]

Rebased on 16.0.

SirAionTech avatar Oct 14 '24 07:10 SirAionTech