commission icon indicating copy to clipboard operation
commission copied to clipboard

[FIX][12.0]sale_commission: fix internal error trying to print int using %s

Open odooNextev opened this issue 1 year ago • 7 comments

odooNextev avatar Aug 02 '23 15:08 odooNextev

Hi @pedrobaeza, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Aug 02 '23 15:08 OCA-git-bot

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Dec 03 '23 12:12 github-actions[bot]

@pedrobaeza Could you please check this simple fix? Thanks

odooNextev avatar Dec 04 '23 07:12 odooNextev

But why is this needed? This was working on my side, converting the int to string by Python itself.

pedrobaeza avatar Dec 04 '23 07:12 pedrobaeza

On my side I had this error before this fix. Maybe it is because I was working with python 3.6. /odoo/lib/python3.6/site-packages/odoo/addons/sale_commission/models/sale_commission_mixin.py", line 67, in _compute_commission_status ) % len(line.agents) TypeError: not all arguments converted during string formatting

odooNextev avatar Dec 04 '23 07:12 odooNextev

Maybe it's a question of translations? Are you using it in English or any other language?

pedrobaeza avatar Dec 04 '23 07:12 pedrobaeza

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Apr 14 '24 14:04 github-actions[bot]