OCA
[18.0][MIG] analytic_brand: Migration to 18.0
@bosd, I removed test file.Please review the PR when you get a chance.
@bosd, Apologies, this was added by mistake. I’ll make sure to avoid it in the future.Please Review.
@bosd, Apologies, this was added by mistake. I’ll make sure to avoid it in the future.Please Review.
The test-requirements.txt was once needed to pass the test. When the mentioned modules were not merged. Since they are merged, the test-requirements.txt file can be empty. Like you did.
But the two commits for editing that file are still in the history. Can you please remove them? You can do this from the terminal:
$ git rebase -i HEAD~2
Your text editor will open and show you the last 2 commits.
You can replace the words pick with the letter d.
sve and close the editor. Then invoika a
$ git push --force-with-lease
This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
@BhaveshHeliconia @bosd please have a look at #244 I think that replacing analytic account by analytic distribution as Odoo/OCA did at many places can be interesting.
@BhaveshHeliconia @bosd please have a look at #244 I think that replacing analytic account by analytic distribution as Odoo/OCA did at many places can be interesting.
Indeed, replacing the analytic account with a distribution is necessary to stay up to date with Odoo's analytics system.
I will merge this PR as standard migration and keep the improvement in #244
This PR looks fantastic, let's merge it! Prepared branch 18.0-ocabot-merge-pr-231-by-sbejaoui-bump-nobump, awaiting test results.
Congratulations, your PR was merged at cf46350be52cd8f15be14d27becb1269b106b5f9. Thanks a lot for contributing to OCA. ❤️