OCA
[18.0][MIG] brand_external_report_layout
Hi, could you please rebase to include changes made in v16 here: https://github.com/OCA/brand/pull/238 ? Thanks
Hi,
Folder layout doesn't show header and color style options.
The rest of layouts seem to be ok.
On my way to merge this fine PR! Prepared branch 18.0-ocabot-merge-pr-224-by-yvaucher-bump-nobump, awaiting test results.
@yvaucher your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-224-by-yvaucher-bump-nobump.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
What a great day to merge this nice PR. Let's do it! Prepared branch 18.0-ocabot-merge-pr-224-by-yvaucher-bump-nobump, awaiting test results.
@yvaucher your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-224-by-yvaucher-bump-nobump.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
@bosd partner_brand/tests/test_partner_brand.py", line 66, in test_empty_brand_logo is failing. Have you checked for conflict with another module?
@bosd PS are you at the OCA Days? Will be there this evening and tomorrow.
Have not checked it with conflicting modules.
On my way to merge this fine PR! Prepared branch 18.0-ocabot-merge-pr-224-by-yvaucher-bump-nobump, awaiting test results.
With the patch on partner_brand it should not interfer with the other module. Let's see if the merge works.
@yvaucher your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-224-by-yvaucher-bump-nobump.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
Hi @bosd
I checked on my side and removed the default image for the logo to fix the tests in partner_brand. I don't really see the value of this default logo.?
Also I detected some issues.
- rendering Boxed and Bold template caused a traceback in the wizard.
- The brand colors where not applied on documents. This modules dynamically creates an asset for the brand colors. You need to keep it in the manifest even if it seems useless at first glance.
I did the modifications there https://github.com/jguenat/brand/pull/5
Feel free to chery-pick/fixup what you need.
