brand icon indicating copy to clipboard operation
brand copied to clipboard

[IMP] product_brand: remove global ACL and specify explicit routes for each line.

Open lef-adhoc opened this issue 1 year ago • 2 comments

See more info here: Odoo commit

lef-adhoc avatar Feb 09 '24 12:02 lef-adhoc

Hi @gurneyalex ! This is a fix to avoid the new warning introduced in Odoo v17 about ACL rules without group: Rule product.brand.public has no group, this is a deprecated feature. Every access-granting rule should specify a group. Can we merge?

bruno-zanotti avatar Feb 15 '24 14:02 bruno-zanotti

Hi @sbejaoui may you check this ?

lef-adhoc avatar Mar 19 '24 18:03 lef-adhoc

Hello @lef-adhoc

Sorry, I didn't see your MR before proceeding with mine.

Please validate this MR: https://github.com/OCA/brand/pull/206

randall-vx avatar Jul 12 '24 23:07 randall-vx

Hi @randall-vx the new standard is to add a ACL for each user type.. so this PR is still needed, @lef-adhoc can you solve the conflicts leaving only the missing rules?

bruno-zanotti avatar Jul 15 '24 21:07 bruno-zanotti

@bruno-zanotti there I added only the missing rules

lef-adhoc avatar Jul 16 '24 14:07 lef-adhoc

/ocabot merge minor

gurneyalex avatar Jul 20 '24 15:07 gurneyalex

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 17.0-ocabot-merge-pr-188-by-gurneyalex-bump-minor, awaiting test results.

OCA-git-bot avatar Jul 20 '24 15:07 OCA-git-bot

Congratulations, your PR was merged at 1589852de24e61f889028c4fc1e9861c15593426. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Jul 20 '24 15:07 OCA-git-bot