OCA
[IMP] brand_external_report_layout : keep original company for report…
…s and just temporarily use brand data
- do not use company details and footer from brand, so that it could be used in multi-company
- this avoid conflicts with other modules overriding company to add information in reports
Fixes #167 Fixes #179
Hi @sbejaoui, some modules you are maintaining are being modified, check this out!
Hi @sbejaoui and others,
In this PR, I had to make some arbitrary choices about the list of fields to override... Maybe we can offer the final user some flexibility using config parameters...
Do not hesitate to review, give advice, discuss.
Regards,
Hello everyone,
Before spending more time on test coverage, I'd like some thoughts about this implementation.
I think avoiding conflicts with other modules and enabling multi-company is necessary for larger adoption, but I'm not sure about updating company with brand data during report rendering and choices made about fields to really consider...
Anyone ? @sbejaoui ? @pierre-halleux ? @jdoutreloux ?
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @sbejaoui
Can we work on this PR and avoid related issues being auto closed ?
@diniciacci gave feedback on related issues...
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.