bank-statement-import icon indicating copy to clipboard operation
bank-statement-import copied to clipboard
verified publisher icon OCA

[FIX] duplicate unique_import_id upon multiple entries in one transaction

Open thomaspaulb opened this issue 3 years ago • 1 comments

When dealing with a statement that has multiple entries for the same transaction, the unique_import_id is set the same for all these entries, hence importing such a statement produces an error of bank account transaction can be imported only once. This solves that issue.

BEFORE

NL20ABNA1234567890-0123456789.2022-06-280001
NL20ABNA1234567890-0123456789.2022-06-280002
NL20ABNA1234567890-0123456789.2022-06-280003
NL20ABNA1234567890-0123456789.2022-06-280004
NL20ABNA1234567890-0123456789.2022-06-280005
NL20ABNA1234567890-0123456789.2022-06-280006
NL20ABNA1234567890-0123456789.2022-06-280007
NL20ABNA1234567890-0123456789.2022-06-280008
NL20ABNA1234567890-0123456789.2022-06-280009
NL20ABNA1234567890-0123456789.2022-06-280010
NL20ABNA1234567890-0123456789.2022-06-280011
NL20ABNA1234567890-0123456789.2022-06-280011  # fails
NL20ABNA1234567890-0123456789.2022-06-280011
NL20ABNA1234567890-0123456789.2022-06-280011

AFTER:

NL20ABNA1234567890-0123456789.2022-06-280001
NL20ABNA1234567890-0123456789.2022-06-280002
NL20ABNA1234567890-0123456789.2022-06-280003
NL20ABNA1234567890-0123456789.2022-06-280004
NL20ABNA1234567890-0123456789.2022-06-280005
NL20ABNA1234567890-0123456789.2022-06-280006
NL20ABNA1234567890-0123456789.2022-06-280007
NL20ABNA1234567890-0123456789.2022-06-280008
NL20ABNA1234567890-0123456789.2022-06-280009
NL20ABNA1234567890-0123456789.2022-06-280010
NL20ABNA1234567890-0123456789.2022-06-280011
NL20ABNA1234567890-0123456789.2022-06-280011-1
NL20ABNA1234567890-0123456789.2022-06-280011-2
NL20ABNA1234567890-0123456789.2022-06-280011-3

thomaspaulb avatar Jul 01 '22 07:07 thomaspaulb

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Jul 06 '22 08:07 OCA-git-bot

/ocabot merge patch

dreispt avatar Oct 01 '22 14:10 dreispt

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 8.0-ocabot-merge-pr-475-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot avatar Oct 01 '22 14:10 OCA-git-bot

Congratulations, your PR was merged at 1b0bfc7e19c72589c18d26e8b5377dd967e10917. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Oct 01 '22 14:10 OCA-git-bot