bank-statement-import icon indicating copy to clipboard operation
bank-statement-import copied to clipboard

[14.0] [IMP] account_statement_import_camt: unique statement names

Open hailangvn opened this issue 3 years ago • 4 comments

  • Most import formats provide unique transaction ids, which allows to ensure no redundant import happens (https://github.com/OCA/bank-statement-import/blob/14.0/account_statement_import/models/account_bank_statement_line.py#L14) CAMT format doesn't, so we add a new feature to check for uniqueness at the statement name level

  • The block Bank & Cash is only visible to group_account_user (https://github.com/odoo/odoo/blob/14.0/addons/account/views/res_config_settings_views.xml#L448). But admin is group_account_manager so he cannot view the block (https://github.com/odoo/odoo/blob/14.0/addons/account/security/account_security.xml#L25). That is why Bank Statement Import block is added for new config parameter.

hailangvn avatar Nov 04 '21 08:11 hailangvn

Thanks @sebalix for the suggestion. This PR has been updated.

hailangvn avatar Nov 09 '21 02:11 hailangvn

@sebalix can you get back to this?

@StefanRijnhart could you have a look at this?

simahawk avatar Jun 01 '22 11:06 simahawk

Thanks @TeoGoddet for your comment. IMHO, it is simpler to just set at one place to have consistent behavior instead of setting multiple journals. I will check the journal option when situation is changed.

hailangvn avatar Jun 16 '22 02:06 hailangvn

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Oct 16 '22 12:10 github-actions[bot]

@simahawk sorry for the delay, can you re-open this so I can approve? We should port this in next versions I guess

sebalix avatar Nov 21 '22 07:11 sebalix

Thanks @StefanRijnhart and @sebalix for your review. This PR has been updated and re-based.

hailangvn avatar Nov 26 '22 08:11 hailangvn