bank-payment icon indicating copy to clipboard operation
bank-payment copied to clipboard

Published 20 hours ago • verified publisher icon OCA

[15.0][FIX] account_payment_order: Fixing newId issue

Open tbanevicius opened this issue 2 years ago • 5 comments

This fix will make bank journal populate after payment mode on change.

fixes #950

tbanevicius avatar Aug 12 '22 11:08 tbanevicius

The diff for this PR seems quite large. Are all of these changes necessary for this fix? It seems you might not have branched from 15.0?

I'm not a maintainer, but it feels like it would be better if you limited this PR to only the changes necessary to fix #950 . Makes it easier for reviewers to go through the code that is relevant to the fix.

aisopuro avatar Aug 16 '22 13:08 aisopuro

The diff for this PR seems quite large. Are all of these changes necessary for this fix? It seems you might not have branched from 15.0?

I'm not a maintainer, but it feels like it would be better if you limited this PR to only the changes necessary to fix #950 . Makes it easier for reviewers to go through the code that is relevant to the fix.

@aisopuro Thanks for noticing, I fixed commits.

tbanevicius avatar Aug 16 '22 13:08 tbanevicius

That's because there are 2 journals linked to that payment mode, isn't it?

pedrobaeza avatar Oct 08 '22 10:10 pedrobaeza

That's because there are 2 journals linked to that payment mode, isn't it?

It is. With only 1 journal linked it is populated.

That's why I said:

If payment mode is Link to Bank Account | Variable: How should be populated?

Just informing in order to decide which is the most common and desired functionality 😄

rafaelbn avatar Oct 10 '22 08:10 rafaelbn

I don't think you should popular any bank account.

pedrobaeza avatar Oct 12 '22 13:10 pedrobaeza