bank-payment icon indicating copy to clipboard operation
bank-payment copied to clipboard

[14.0][FIX] Fire trigger only when purchase_vendor_bill field has been changed

Open ChrisOForgeFlow opened this issue 2 years ago • 1 comments

@ForgeFlow

ChrisOForgeFlow avatar May 27 '22 12:05 ChrisOForgeFlow

@ChrisOForgeFlow Can you comment on Pedro's question please?

dreispt avatar Aug 10 '22 21:08 dreispt

I think you have to change instead new_mode and new_bank variables for not assigning current one if no new is set.

I'm not sure if payment_mode_id should be changed with empty value(Empty values of new_move, new_bank), because that I tried to fire change only when field purchase_vendor_bill_id is assigned, otherwise the field will be empty even when the onchange is fired by an empty field, like purchase_id

Because that I think that change only be triggered when field is not empty

ChrisOForgeFlow avatar Aug 26 '22 18:08 ChrisOForgeFlow

@ChrisOForgeFlow Can you comment on Pedro's question please?

Done, thanks

ChrisOForgeFlow avatar Aug 26 '22 18:08 ChrisOForgeFlow

That's not what I was saying. I want to avoid such convoluted code for not changing what is not needed.

pedrobaeza avatar Aug 27 '22 13:08 pedrobaeza

The proper fix IMO is #955, that is already in 13.0. Can we close this one in favor of the other?

pedrobaeza avatar Aug 29 '22 09:08 pedrobaeza

Closing in favor of #955 as no more comments.

pedrobaeza avatar Sep 01 '22 20:09 pedrobaeza