bank-payment
bank-payment copied to clipboard
OCA
[ENH][14.0] bank-payment Fallback to payment_ref if ref is undefined
The payment order report in PDF format has a field "Invoice Ref", which user the move.ref. In my use case, the move.ref is always blank for a vendor bill, as I prefer not duplicating information in the vendor bill import. This pull request uses the payment_reference if the ref field is absent. A case might even be made to prefer the payment_reference over the ref if both are available but that might cause regressions.
Current report:
Partner Bank account Invoice Ref Value Date Amount Currency
Deco Addict NL01BANK012345 2022-03-17 100.00 100.00
Desired report:
Partner Bank account Invoice Ref Value Date Amount Currency
Deco Addict NL01BANK012345 X/220002 2022-03-17 100.00 100.00
This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
hi @dreispt , I think you ran the wrong command, should be with an A ;-) /ocabot merge minor
Sorry @flotho you are not allowed to merge.
To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.
If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.
On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-911-by-adrienpeiffer-bump-minor, awaiting test results.
It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-911-by-adrienpeiffer-bump-minor, awaiting test results.
Congratulations, your PR was merged at 47a22cc86f28dc030dd786989afd63c9b7b97ef3. Thanks a lot for contributing to OCA. ❤️