account-reconcile icon indicating copy to clipboard operation
account-reconcile copied to clipboard

[16.0] account_reconcile_oca makes two fields have the same label

Open gjotten opened this issue 8 months ago • 2 comments

When upgrading account_reconcile_oca the following warning gets thrown:

Two fields (company_currency_id, currency_id) of account.journal() have the same label: Currency. [Modules: account_reconcile_oca and account]

In account_reconcile_oca.pot we see the following field labeling defined:

#. module: account_reconcile_oca
#: model:ir.model.fields,field_description:account_reconcile_oca.field_account_account_reconcile__company_currency_id
#: model:ir.model.fields,field_description:account_reconcile_oca.field_account_account_reconcile__currency_id
#: model:ir.model.fields,field_description:account_reconcile_oca.field_account_bank_statement_line__company_currency_id
#: model:ir.model.fields,field_description:account_reconcile_oca.field_account_journal__company_currency_id
#: model:ir.model.fields,field_description:account_reconcile_oca.field_account_reconcile_abstract__company_currency_id
#: model:ir.model.fields,field_description:account_reconcile_oca.field_account_reconcile_abstract__currency_id
msgid "Currency"
msgstr ""

Might I suggest splitting off company_currency_id to be defined as "Company Currency" for good housekeeping and some future-proofing?

gjotten avatar Jun 10 '24 08:06 gjotten