account-payment icon indicating copy to clipboard operation
account-payment copied to clipboard

[18.0] [MIG] account_move_line_payment: Migration to 18.0

Open RedaKarimi opened this issue 2 months ago • 11 comments

RedaKarimi avatar Oct 20 '25 13:10 RedaKarimi

@yajo @rafaelbn is it ok the migration? thank you

mmircoli-nexapp avatar Oct 21 '25 09:10 mmircoli-nexapp

/ocabot migration account_move_line_payment

mmircoli-nexapp avatar Oct 21 '25 12:10 mmircoli-nexapp

Sorry @mmircoli-nexapp you are not allowed to mark the addon to be migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

OCA-git-bot avatar Oct 21 '25 12:10 OCA-git-bot

@pedrobaeza is it ok the pull request? thank you

mmircoli-nexapp avatar Oct 23 '25 14:10 mmircoli-nexapp

The PR title was not OK. Changed.

Commit history and formal process seems OK. Now reviewers should confirm the correct code and functional behavior.

/ocabot migration account_move_line_payment

pedrobaeza avatar Oct 23 '25 14:10 pedrobaeza

@yajo @rafaelbn is it ok the migration? thank you

ping

mmircoli-nexapp avatar Oct 28 '25 13:10 mmircoli-nexapp

Hello folks! We will not use this module for v17+ because Odoo includes the part of it that we need:

image

yajo avatar Oct 29 '25 09:10 yajo

Member

which module implement this action??

mmircoli-nexapp avatar Oct 29 '25 09:10 mmircoli-nexapp

Hello folks! We will not use this module for v17+ because Odoo includes the part of it that we need:

image

do you use some module? I try to check on runbot 18.0 and I don't find this voice of Menu

mmircoli-nexapp avatar Oct 30 '25 10:10 mmircoli-nexapp

Hello folks! We will not use this module for v17+ because Odoo includes the part of it that we need:

image

this module add the function here Screenshot 2025-10-30 alle 17 15 47

And without the module the function is not avaible

mmircoli-nexapp avatar Oct 30 '25 16:10 mmircoli-nexapp

Hello folks! We will not use this module for v17+ because Odoo includes the part of it that we need:

image

I agree your point of view, however if you have more deadlines you need to register only 1 one and not alle total of invoice

mmircoli-nexapp avatar Nov 06 '25 07:11 mmircoli-nexapp

Core behavior was added to v17, but in v18 has been removed again. I think migration of this module is needed.

MT-12596

Shide avatar Nov 11 '25 09:11 Shide

Hello @RedaKarimi ,

Thank you for this migration, please could you review comments from @Shide ?

Thank you Regards, Rafael

rafaelbn avatar Nov 13 '25 07:11 rafaelbn

@RedaKarimi can you apply https://github.com/OCA/account-payment/pull/892#discussion_r2517379014 changes?

Shide avatar Nov 19 '25 08:11 Shide

@RedaKarimi can you apply #892 (comment) changes?

Hi my collegue is busy in this period, if you want do a PR to our branch or do a super seed for us there is no problem

mmircoli-nexapp avatar Nov 19 '25 08:11 mmircoli-nexapp

Please check out https://github.com/OCA/account-payment/pull/913 for next reviews

Shide avatar Dec 04 '25 12:12 Shide