account-payment icon indicating copy to clipboard operation
account-payment copied to clipboard

[16.0][MIG] account_payment_tier_validation: backport to v16

Open quirino95 opened this issue 5 months ago • 3 comments

quirino95 avatar Jul 18 '25 12:07 quirino95

Thank you @SirPyTech ! I did format-patch and squashed commits. I've updated also behavior in account_payment.py by taking code from the "previous attempt", and as consequence all tests are now ok!

quirino95 avatar Jul 22 '25 15:07 quirino95

Thank you Simone for the explanation. Now it's clearer for me, so I updated code. I hope now everything is fine.

quirino95 avatar Jul 31 '25 08:07 quirino95

After https://github.com/OCA/server-ux/pull/1135, I had to change a couple of occurences of validated field, which not exists in server-ux for 16.0. I replaced it with validation_status = 'validated'

quirino95 avatar Aug 01 '25 13:08 quirino95

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Nov 30 '25 12:11 github-actions[bot]

/ocabot merge nobump

rvalyi avatar Nov 30 '25 15:11 rvalyi

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 16.0-ocabot-merge-pr-859-by-rvalyi-bump-nobump, awaiting test results.

OCA-git-bot avatar Nov 30 '25 15:11 OCA-git-bot

@rvalyi your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-859-by-rvalyi-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

OCA-git-bot avatar Nov 30 '25 15:11 OCA-git-bot

Rebased to check merge failure

SirPyTech avatar Dec 01 '25 08:12 SirPyTech

Fixed tests failure!

quirino95 avatar Dec 01 '25 13:12 quirino95

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Dec 07 '25 13:12 OCA-git-bot

/ocabot merge nobump

(from https://github.com/OCA/account-payment/pull/859#issuecomment-3592697369)

@rvalyi please try again

SirPyTech avatar Dec 09 '25 08:12 SirPyTech

@SirPyTech @quirino95

Thanks for considering my old PR

alexeirivera87 avatar Dec 11 '25 22:12 alexeirivera87