account-payment icon indicating copy to clipboard operation
account-payment copied to clipboard

Published 20 hours ago • verified publisher icon OCA

[14.0] [FIX] account_payment_term_discount: Difference in rounding

Open majouda opened this issue 10 months ago • 4 comments

In the context of this module's application, we encountered a specific issue involving:

  • Discount Amount: 229.95
  • Payment Difference: 229.95000000000002

Although there is no rounding in _compute_payment_difference() of account module and this module performs rounding in _compute_discount_amt().

This discrepancy in rounding can lead to different comparison results.

This commit aims to rectify the inconsistency in rounding between these two fields, ensuring accurate comparisons.

majouda avatar Apr 19 '24 16:04 majouda

Hi @bodedra, some modules you are maintaining are being modified, check this out!

OCA-git-bot avatar Apr 19 '24 16:04 OCA-git-bot

@majouda Thanks for your contribution. Would you add screenshot or example before and after this PR changes, please?

bodedra avatar Apr 19 '24 17:04 bodedra

@majouda Thanks for your contribution. Would you add screenshot or example before and after this PR changes, please?

Hello @bodedra I added a description to this PR, can you check plz if it's clear now?

majouda avatar May 31 '24 21:05 majouda

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Jun 11 '24 17:06 OCA-git-bot