account-payment 16.0 mig account payment batch process

Dec 15 '23 17:12 noharr

Hi @pedrobaeza , I would like to understand why @noharr 's PR is rejected about code coverage, whereas the version 15.0 of this module were merged without any tests here: https://github.com/OCA/account-payment/pull/539

We will try to add some tests to increase coverage but was there a special treatment about version 15.0?

Thanks for your help!

Dec 18 '23 14:12 isabellerichard

It's not rejected. It's simply that the code coverage has lowered applying with this PR. It's a quality metric, but it's not enforced for merging modules. The other metrics should be green though. Check https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/oca_module_lifecycle_development_status.rst for information about the requirements.

Dec 18 '23 16:12 pedrobaeza

Hi everyone,

#564 is already approved for migrating account_payment_batch_process and none of them are listed in #546

Can someone with sufficient rights helps to mutualize the efforts ?

Jan 09 '24 10:01 metaminux

I'm rather troubled that we have a payment related module in the OCA without any unit test. #564 has a serious issue that would not have gone unnoticed otherwise. Would you consider to add the tests in this PR?

Feb 14 '24 10:02 StefanRijnhart

Hey there, I added a test over in https://github.com/OCA/account-payment/pull/716 to move this forward.

Mar 08 '24 14:03 robinkeunen

Superseded by https://github.com/OCA/account-payment/pull/716

Jun 17 '24 06:06 JordiBForgeFlow