account-invoicing icon indicating copy to clipboard operation
account-invoicing copied to clipboard

[ADD] account_invoice_analytic_line

Open hbrunn opened this issue 6 years ago • 17 comments

This module is a rewrite of the deprecated v8 module hr_timesheet_invoice.

It allows you to invoice analytic lines derived from time recorded on project tasks to the project's customer without a detour via sales orders. The invoice analytic lines will be attached to the invoice document when printed.

hbrunn avatar Dec 10 '18 07:12 hbrunn

@hbrunn is there a runbot instance for this branch? I would like to review and test it.

Regards Nikolina

ntodorova avatar Mar 08 '19 13:03 ntodorova

@ntodorova please read https://odoo-community.org/page/review, this will explain how to recreate the runbot instance

hbrunn avatar Mar 11 '19 12:03 hbrunn

@hbrunn, I have read it - it is written "On the next page, click on the blue square (if there is none, leave a comment on Github) and log into Odoo with the following credentials:". I don`t see the icon, I have force rebuild, but also nothing happens

ntodorova avatar Mar 11 '19 12:03 ntodorova

you need to wait a few minutes, this should be done 10 or so

hbrunn avatar Mar 11 '19 13:03 hbrunn

I am testing the module and when I create an Invoice, I don't see the discount on the line: Screenshot from 2019-03-18 11-37-41

As you see the discount is applied (Line one has 50% discount), but it is not mentioned anywhere. Is that how it should be?

ntodorova avatar Mar 18 '19 10:03 ntodorova

you don't have the Show discount on invoice lines (or similar name) group activated

hbrunn avatar Mar 18 '19 10:03 hbrunn

Yes, now all is fine. So I have review and test. You have answered all my questions. From my side the module is OK

ntodorova avatar Mar 18 '19 10:03 ntodorova

I would prefer the name account_analytic_line_invoicing for a better description of the aim of the module. Apart from that, the module seems OK.

pedrobaeza avatar Jun 17 '19 18:06 pedrobaeza

Is the play onchanges working? When I create the invoice from the analytic lines the account_id is not set so the configuration error raises. When creating the invoice with the same product manually the account is filled accordingly.

AaronHForgeFlow avatar Jun 19 '19 10:06 AaronHForgeFlow

@aheficent this works as it should for us in production for a while. Can you reproduce the problem on runbot?

hbrunn avatar Jun 20 '19 07:06 hbrunn

@hbrunn I tested on runbot indeed: analytic

I set this product image

and the accounts seems set in the product.

Are there anything else I should have configured before?

AaronHForgeFlow avatar Jun 20 '19 09:06 AaronHForgeFlow

ah, you need to set a customer on the project(s) you want to invoice. A better error message about that would be nice indeed

hbrunn avatar Jun 20 '19 10:06 hbrunn

@hbrunn what do you think about the module name?

pedrobaeza avatar Jun 20 '19 10:06 pedrobaeza

I take you suggestion as the opinion of a single OCA member, given we have two approvals and you're a little bit late to the party ;-)

hbrunn avatar Jun 20 '19 10:06 hbrunn

OK, no problem

pedrobaeza avatar Jun 20 '19 10:06 pedrobaeza

Is there an OCA module which contains similar functionality to this but for later versions? (v12>) I am looking for a way to create invoices from analytic lines, not only timesheet lines but also analytic lines for consumable and stockable products. If not so is it something which could be proposed?

CasVissers-360ERP avatar Nov 09 '20 07:11 CasVissers-360ERP

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Aug 07 '22 12:08 github-actions[bot]