account-invoicing
account-invoicing copied to clipboard
[17.0][ADD] acount_move_tags: add module
LGTM
@OCA/accounting-maintainers can you review?
Thanks for the contribution. Please avoid plurals on module names as stated in https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#modules. You can call it account_move_tag for example (although we know that it can be more than one tag). It's a technical name, and thus, it shouldn't reflect the "language correction". Why plurals should be avoided is for avoiding frequent typos typing the module name. Imagine an extension module account_move_tags_images, and then account_move_tags_images_relative, and so on: you'll end up putting s where it's not and not putting them when it should.
Please also squash both commits.
Thanks for the contribution. Please avoid plurals on module names as stated in https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#modules. You can call it
account_move_tagfor example (although we know that it can be more than one tag). It's a technical name, and thus, it shouldn't reflect the "language correction". Why plurals should be avoided is for avoiding frequent typos typing the module name. Imagine an extension moduleaccount_move_tags_images, and thenaccount_move_tags_images_relative, and so on: you'll end up putting s where it's not and not putting them when it should.Please also squash both commits.
Thanks @pedrobaeza for the feedback and explanation! Review of the updated module is much appreciated :)
@pedrobaeza can this be merged?
/ocabot merge nobump
On my way to merge this fine PR! Prepared branch 17.0-ocabot-merge-pr-1809-by-pedrobaeza-bump-nobump, awaiting test results.
Congratulations, your PR was merged at 9038df82fffeb5fdbbbb24f6e2d61998bd40f732. Thanks a lot for contributing to OCA. ❤️