account-invoicing icon indicating copy to clipboard operation
account-invoicing copied to clipboard

[17.0][ADD] acount_move_tags: add module

Open joepsanders opened this issue 1 year ago • 3 comments

joepsanders avatar Oct 04 '24 15:10 joepsanders

LGTM

@OCA/accounting-maintainers can you review?

chrisb-c01 avatar Oct 05 '24 06:10 chrisb-c01

Thanks for the contribution. Please avoid plurals on module names as stated in https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#modules. You can call it account_move_tag for example (although we know that it can be more than one tag). It's a technical name, and thus, it shouldn't reflect the "language correction". Why plurals should be avoided is for avoiding frequent typos typing the module name. Imagine an extension module account_move_tags_images, and then account_move_tags_images_relative, and so on: you'll end up putting s where it's not and not putting them when it should.

Please also squash both commits.

pedrobaeza avatar Oct 05 '24 11:10 pedrobaeza

Thanks for the contribution. Please avoid plurals on module names as stated in https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#modules. You can call it account_move_tag for example (although we know that it can be more than one tag). It's a technical name, and thus, it shouldn't reflect the "language correction". Why plurals should be avoided is for avoiding frequent typos typing the module name. Imagine an extension module account_move_tags_images, and then account_move_tags_images_relative, and so on: you'll end up putting s where it's not and not putting them when it should.

Please also squash both commits.

Thanks @pedrobaeza for the feedback and explanation! Review of the updated module is much appreciated :)

joepsanders avatar Oct 06 '24 08:10 joepsanders

@pedrobaeza can this be merged?

joepsanders avatar Oct 01 '25 13:10 joepsanders

/ocabot merge nobump

pedrobaeza avatar Oct 03 '25 14:10 pedrobaeza

On my way to merge this fine PR! Prepared branch 17.0-ocabot-merge-pr-1809-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot avatar Oct 03 '25 14:10 OCA-git-bot

Congratulations, your PR was merged at 9038df82fffeb5fdbbbb24f6e2d61998bd40f732. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Oct 03 '25 14:10 OCA-git-bot