account-invoicing icon indicating copy to clipboard operation
account-invoicing copied to clipboard

[16.0][IMP] account_invoice_fixed_discount: avoid replace in xml

Open CRogos opened this issue 2 years ago • 3 comments

I am currently facing a problem with to many decimal numbers in a standard Odoo installation on the invoice PDF. image

I assume this causes by this code section: image

I also evaluated that adding this options will solve the issue in standard Odoo: t-options='{"widget": "float", "decimal_precision": "Discount"}'

https://github.com/odoo/odoo/blob/5911f056f9ed45a82a694782f82aa3170d0b74ac/addons/account/views/report_invoice.xml#L126C49-L126C100

But this module is using replace, which would bring back the problem. Therefore I would like to change the xml not using "replace".

CRogos avatar Nov 03 '23 13:11 CRogos

@PieterPaulussen could you review?

CRogos avatar Nov 03 '23 14:11 CRogos

@JordiBForgeFlow could you review and merge this?

CRogos avatar Mar 25 '24 20:03 CRogos

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Mar 27 '24 12:03 OCA-git-bot

/ocabot merge patch

JordiBForgeFlow avatar Apr 04 '24 09:04 JordiBForgeFlow

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 16.0-ocabot-merge-pr-1593-by-JordiBForgeFlow-bump-patch, awaiting test results.

OCA-git-bot avatar Apr 04 '24 09:04 OCA-git-bot

Congratulations, your PR was merged at d481144f5feefa9e473c988a4acfff786ac2e6ed. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Apr 04 '24 09:04 OCA-git-bot