account-invoicing icon indicating copy to clipboard operation
account-invoicing copied to clipboard

[15.0][MIG] account_invoice_base_invoicing_mode (renamed)

Open TDu opened this issue 3 years ago • 3 comments

TDu avatar Sep 26 '22 08:09 TDu

I just added the migration script for the module rename

TDu avatar Sep 30 '22 12:09 TDu

I don't think that the renaming works in the migration of module itself. The renaming has to be done here: https://github.com/OCA/OpenUpgrade/blob/15.0/openupgrade_scripts/apriori.py#L6

Ok, I based that on existing commit in other repos. Do you mean I have to open a PR on openupgrade ?

TDu avatar Oct 17 '22 06:10 TDu

Yes please! In that PR, please link to this PR so that we can merge in tandem.

StefanRijnhart avatar Oct 17 '22 09:10 StefanRijnhart

@TDu please remove that migration bit in this PR, then we can go ahead with it.

StefanRijnhart avatar Nov 18 '22 13:11 StefanRijnhart

/ocabot migration account_invoice_base_invoicing_mode

rafaelbn avatar Dec 09 '22 19:12 rafaelbn

The migration issue (#1022) has been updated to reference the current pull request. however, a previous pull request was referenced : #1061. Perhaps you should check that there is no duplicate work. CC : @rven

OCA-git-bot avatar Dec 09 '22 19:12 OCA-git-bot

I removed the migration script

TDu avatar Dec 12 '22 08:12 TDu

@simahawk ? you merged it in v13 😄 https://github.com/OCA/account-invoicing/pull/755

rafaelbn avatar Dec 13 '22 17:12 rafaelbn

@pedrobaeza this PR is ready to be merge :) Thanks

houssine78 avatar Apr 18 '23 15:04 houssine78

Merging blindly due to the reviews:

/ocabot merge nobump

pedrobaeza avatar Apr 18 '23 15:04 pedrobaeza

On my way to merge this fine PR! Prepared branch 15.0-ocabot-merge-pr-1243-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot avatar Apr 18 '23 15:04 OCA-git-bot

Congratulations, your PR was merged at 3b6145450a19a3c55b90f2394fcd27cc0e8734cf. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Apr 18 '23 16:04 OCA-git-bot