account-invoicing icon indicating copy to clipboard operation
account-invoicing copied to clipboard

[MIG] account_invoice_mode_at_shipping: Migration to 15.0

Open BertVGroenendael opened this issue 3 years ago • 5 comments

BertVGroenendael avatar Feb 14 '22 15:02 BertVGroenendael

@BertVGroenendael can you please fix build?

ajaniszewska-dev avatar Feb 18 '22 12:02 ajaniszewska-dev

@BertVGroenendael can you please fix build?

@ajaniszewska-dev This build cannot be fixed at this moment because it depends on account_invoice_base_invoicing_mode which is also in PR https://github.com/OCA/account-invoicing/pull/1061

rven avatar Feb 18 '22 12:02 rven

test-requirements.txt Do you mean this https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#185oca_dependenciestxt? Does this also work for modules in the same repository?

rven avatar Feb 18 '22 12:02 rven

test-requirements.txt Do you mean this https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#185oca_dependenciestxt? Does this also work for modules in the same repository?

yes, however afair there is no test-requirements specified in this doc (i don't know why). How it was worked for me, to add in separate commit test-requirements.txt file with content inside:

git+https://github.com/OCA/$REPO@refs/pull/$PR_number/head#subdirectory=setup/$MODULE you should replace everything starting with $ so in your case syntax in the file would be something like:

git+https://github.com/OCA/account-invoicing@refs/pull/1061/head#subdirectory=setup/account_invoice_base_invoicing_mode

plus worth add note in PR description that it depends on PR (PR number) and dependency file was updated in the separate commit.

ajaniszewska-dev avatar Feb 18 '22 12:02 ajaniszewska-dev

This module depends on https://github.com/OCA/account-invoicing/pull/1061. test-requirements.txt file added in separated commit.

rven avatar Feb 18 '22 13:02 rven

Closing in favour of https://github.com/OCA/account-invoicing/pull/1247. I have now based the 16.0 migration of the module on that PR. Thank you nevertheless for your contribution!

StefanRijnhart avatar Nov 30 '22 20:11 StefanRijnhart