account-financial-tools
account-financial-tools copied to clipboard
OCA
[12.0][ADD] account_payment_intransit
change name from account_bank_receipt to account_payment_intransit This module manage payment in-transit (i.e. Received post date check) Base on account_check_deposit
I'm not sure what in-transit means, but this sound very similar to the payment order transfer account feature that move the balance from one receivable/payable account to another (AR or not).
@pedrobaeza
I'm not sure what in-transit means, but this sound very similar to the payment order transfer account feature that move the balance from one receivable/payable account to another (AR or not).
@pedrobaeza It is not a transfer AR/AP to another. Actually it is for manage and internal control Bank account. This is another process (document) after reconcile AR/AP on account.voucher but user doesn't want to record to cash or bank on this document. They want to suspend it. So we have to have Payment/bank in-transit account. Once money reach their bank statement, user will reconcile payment/bank in-transit to their bank account.
Comparable to Goods in-transit or GR/not IR on stock accounting.
P.S. I am not a programmer if my words are not clear, pls suggest.
@pedrobaeza actually we just rename it from account_bank_receipt (which was based on idea of account_check_deposit). We think this name is more generic, because it is possible to work both inbound and outbound (i.e., next iteration)
Reading your clarifications, I still think it's something similar, but I'm not blocking this.
@Saran440 please improve code coverage. I think you can test the cancel case.
Reading your clarifications, I still think it's something similar, but I'm not blocking this.
@pedrobaeza yes, I have look into the payment order, it is a great module. But I think it is quite complicated in term of setting and use for this kind of use case. Thank you for not blocking this.
@pedrobaeza, if you not objecting, I will move this module (and all its extension) to https://github.com/OCA/l10n-thailand Thanks! cc @Saran440
Well, don't you think this can be something generic? Is the problem for moving this to get it merged here?
But no reviews for now. Your team can review the PR (or yourself), and having 2 reviews, no problem in merge it here.
But no reviews for now. Your team can review the PR (or yourself), and having 2 reviews, no problem in merge it here.
Oh yes!. Also, may be I will trade this review with others on the OCA day. Would be fun! :smiling_imp:
This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
What a great day to merge this nice PR. Let's do it! Prepared branch 12.0-ocabot-merge-pr-821-by-kittiu-bump-no, awaiting test results.
On my way to merge this fine PR! Prepared branch 12.0-ocabot-merge-pr-821-by-kittiu-bump-no, awaiting test results.
This PR looks fantastic, let's merge it! Prepared branch 12.0-ocabot-merge-pr-821-by-dreispt-bump-nobump, awaiting test results.
@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-821-by-dreispt-bump-nobump.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
This PR looks fantastic, let's merge it! Prepared branch 12.0-ocabot-merge-pr-821-by-dreispt-bump-nobump, awaiting test results.
@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-821-by-dreispt-bump-nobump.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
Hello @Saran440 @kittiu there is an error check https://github.com/OCA/account-financial-tools/pull/821#issuecomment-709081409 Thank you!