account-financial-tools icon indicating copy to clipboard operation
account-financial-tools copied to clipboard

[10.0] [FIX] account move get journal sequence in name

Open Tonow-c2c opened this issue 6 years ago • 5 comments

Same as this PR https://github.com/acsone/account-financial-tools/pull/6/files but with fresher HEAD

Tonow-c2c avatar Oct 23 '18 07:10 Tonow-c2c

@Tonow-c2c I was asking me a few questions, but it seems like @grindtildeath already asked them. Ping me once you have answers or pushed something else

leemannd avatar Oct 23 '18 14:10 leemannd

travis red build is not related to the PR (branch 10.0 is red at the moment)

gurneyalex avatar Oct 23 '18 16:10 gurneyalex

@grindtildeath and @leemannd I don't now the real impact maybe @mpanarin and @fclementic2c can explain what is the goal to https://github.com/acsone/account-financial-tools/pull/6

Tonow-c2c avatar Oct 23 '18 16:10 Tonow-c2c

this same question came up and has been answered in https://github.com/OCA/account-financial-tools/pull/677.

I think the current default behaviour should be kept. As an alternative we could make it configurable but in my experience (after having this module rolled already to at least 50 environments over the last couple of years) it is primarily an matter of being capable to explain to the customer why we don't use the journal sequence (so far I have had only one case where I made a small inherited module to enforce the journal sequence).

luc-demeyer avatar Oct 24 '18 20:10 luc-demeyer

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Oct 09 '22 12:10 github-actions[bot]