[11.0][MIG]account asset management xls

[luc-demeyer]

[grindtildeath]

Requires :

• [x] #698

[sanrav]

Testing successful

[luc-demeyer]

@grindtildeath Code review & tested commits d6c52f0 and d6c52f0. 👍

When looking to commit d6c52f0: I think it would be better to go one step further and

• make the Asset Filter (parent_asset_id) a required field on the wizard
• move the parents = asset_obj.search( [('type', '=', 'view'), ('parent_id', '=', False)], limit=1) to the default function of the parent_asset_id

@sanrav since this is more a functional than a technical improvement: do you agree with my proposal to make the Asset Filter a required (and prefilled) field ?

[sanrav]

It's important to keep the field Asset filter as a non required field because it's useful to generate the report for all the assets and so all the parent assets.

[luc-demeyer]

@sanrav Can't you put a reporting top level view account for this purpose .? If you test the current module you'll remark that if no filter is specified the first top level parent is chosen, hence we need to review this logic in order to accomodate your request ? I tend to configure it with e.g. three top level view accounts, one for Financial Assets, one for Cost Spreading, one for Revenue spreading. My customers don't make a point of the fact that they need to pull the info via separate exports.

I prefer we merge it like this and start work on an improved reporting module based upon tags with hierarchy (hence we can overlay multiple reporting structures, e.g. a legal one and one more aligned to the customer internal needs).

[grindtildeath]

@luc-demeyer Your last suggestion makes total sense IMO and I did implement it in 2e59810. @sanrav Actually not selecting any parent asset will generate the report for the first parent asset found and not for everything. So it's better in terms of UX to display the parent asset which is going to be used...

[sanrav]

Of course if the field takes the 1st parent by default it's better to show it. I expected that if you don't put anything in the field it takes all the parents. I did my tests with only one parent... That's why I haven't noticed that. I have clients that have 7 different parents. I can't ask them to generate 7 times the report and then make copy-paste in Excel. I've tried to put a top level parent to the parents to generate the report only once by selecting the top level parent but the report generated is empty.

[luc-demeyer]

@sanrav it looks you are hitting a bug here. I'll have a look and come up with a fix when I can reproduce what you experience.

[luc-demeyer]

@sanrav Top level works now. I also fixed an error in the excel template (asset code displayed in asset name column). Can you retest ?

[sanrav]

Ok testing successful ! Thanks !

[luc-demeyer]

I think this one is ready for merge. Can someone hit the merge button ?

[sbidoul]

@luc-demeyer coiuld you resolve the conflict here, then we can merge.

[github-actions[bot]]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.