account-financial-tools icon indicating copy to clipboard operation
account-financial-tools copied to clipboard

[13.0][ADD] account_move_line_cumulated_balance: Show field cumulated balance

Open cesar-tecnativa opened this issue 2 years ago • 12 comments

@Tecnativa TT37842

cesar-tecnativa avatar Jun 30 '22 22:06 cesar-tecnativa

@pedrobaeza could you please review?

cesar-tecnativa avatar Jun 30 '22 22:06 cesar-tecnativa

@chienandalu Please, could you review?

cesar-tecnativa avatar Jun 30 '22 23:06 cesar-tecnativa

@victoralmau could you please review this?

cesar-tecnativa avatar Jul 05 '22 12:07 cesar-tecnativa

@LudLaf could you review this?

cesar-tecnativa avatar Jul 06 '22 19:07 cesar-tecnativa

@LudLaf please review it functionally

pedrobaeza avatar Jul 12 '22 09:07 pedrobaeza

@LudLaf please review it functionally

Just tested. Functionality is working.

LudLaf avatar Jul 12 '22 11:07 LudLaf

@LudLaf do the proper review with GitHub tools

pedrobaeza avatar Jul 12 '22 11:07 pedrobaeza

@cesar-tecnativa something has changed. When trying to test this module, it shows the following:

Please provide steps to reproduce the issue.

chienandalu avatar Aug 11 '22 05:08 chienandalu

@cesar-tecnativa something has changed. When trying to test this module, it shows the following:

Please provide steps to reproduce the issue. Peek 2022-08-11 10-33

LudLaf avatar Aug 11 '22 08:08 LudLaf

@cesar-tecnativa something has changed. When trying to test this module, it shows the following:

Please provide steps to reproduce the issue. Peek 2022-08-11 10-33

    [
      
        ![Peek 2022-08-11 10-33](https://user-images.githubusercontent.com/4016592/184095484-e1d7dc9f-5717-4caf-9d55-7038e913005d.gif)
      
    ](https://user-images.githubusercontent.com/4016592/184095484-e1d7dc9f-5717-4caf-9d55-7038e913005d.gif)
    
    
      
        
          
        
        
          
          
        
      
      [
        
          
        
      ](https://user-images.githubusercontent.com/4016592/184095484-e1d7dc9f-5717-4caf-9d55-7038e913005d.gif)

solved

cesar-tecnativa avatar Aug 11 '22 09:08 cesar-tecnativa

new changes are done

cesar-tecnativa avatar Aug 12 '22 09:08 cesar-tecnativa

new changes are done

Just tried to open the invoicing app, but didn't work.


Error:

Traceback: Error: fieldsViews is undefined _generateActionViews/<@http://oca-account-financial-tools-13-0-pr1438-82728466fadf.runboat.odoo-community.org/web/static/src/js/chrome/action_manager_act_window.js:355:30 _.forEach@http://oca-account-financial-tools-13-0-pr1438-82728466fadf.runboat.odoo-community.org/web/static/lib/underscore/underscore.js:145:17 _generateActionViews@http://oca-account-financial-tools-13-0-pr1438-82728466fadf.runboat.odoo-community.org/web/static/src/js/chrome/action_manager_act_window.js:353:11 _executeWindowAction/<@http://oca-account-financial-tools-13-0-pr1438-82728466fadf.runboat.odoo-community.org/web/static/src/js/chrome/action_manager_act_window.js:258:3 Peek 2022-08-15 10-22 0

LudLaf avatar Aug 15 '22 08:08 LudLaf

Not working on runboat nor when trying to install it in local, so it's not possible to test it functionally. Please check previous review.

I just tested it on runbot. I had to install account_lock_date_update which was missing on some view for any reason.

chienandalu avatar Aug 22 '22 06:08 chienandalu

@chienandalu you can check now. Data is computed in a absolute way record per record with an aggregated SQL, but it's efficient enough on real databases, and it's the only way to get proper data no matter done filters.

pedrobaeza avatar Aug 24 '22 18:08 pedrobaeza

@chienandalu you can check now. Data is computed in a absolute way record per record with an aggregated SQL, but it's efficient enough on real databases, and it's the only way to get proper data no matter done filters.

And won't it produce tons of queries?

chienandalu avatar Aug 25 '22 06:08 chienandalu

As you visualize a limited number of records in these views, that would be the number of queries. It can't be avoided due to the nature of the need.

pedrobaeza avatar Aug 25 '22 06:08 pedrobaeza

/ocabot merge nobump

pedrobaeza avatar Aug 25 '22 06:08 pedrobaeza

What a great day to merge this nice PR. Let's do it! Prepared branch 13.0-ocabot-merge-pr-1438-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot avatar Aug 25 '22 06:08 OCA-git-bot

Congratulations, your PR was merged at 96cbdd4b54c507edc17a3b616f6057441fd1b390. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Aug 25 '22 07:08 OCA-git-bot