account-financial-tools
account-financial-tools copied to clipboard
[13.0][ADD] account_move_line_cumulated_balance: Show field cumulated balance
@Tecnativa TT37842
@pedrobaeza could you please review?
@chienandalu Please, could you review?
@victoralmau could you please review this?
@LudLaf could you review this?
@LudLaf please review it functionally
@LudLaf please review it functionally
Just tested. Functionality is working.
@LudLaf do the proper review with GitHub tools
@cesar-tecnativa something has changed. When trying to test this module, it shows the following:
Please provide steps to reproduce the issue.
@cesar-tecnativa something has changed. When trying to test this module, it shows the following:
Please provide steps to reproduce the issue.
@cesar-tecnativa something has changed. When trying to test this module, it shows the following:
Please provide steps to reproduce the issue.
[  ](https://user-images.githubusercontent.com/4016592/184095484-e1d7dc9f-5717-4caf-9d55-7038e913005d.gif) [ ](https://user-images.githubusercontent.com/4016592/184095484-e1d7dc9f-5717-4caf-9d55-7038e913005d.gif)
solved
new changes are done
new changes are done
Just tried to open the invoicing app, but didn't work.
Error:
Traceback:
Error: fieldsViews is undefined
_generateActionViews/<@http://oca-account-financial-tools-13-0-pr1438-82728466fadf.runboat.odoo-community.org/web/static/src/js/chrome/action_manager_act_window.js:355:30
_.forEach@http://oca-account-financial-tools-13-0-pr1438-82728466fadf.runboat.odoo-community.org/web/static/lib/underscore/underscore.js:145:17
_generateActionViews@http://oca-account-financial-tools-13-0-pr1438-82728466fadf.runboat.odoo-community.org/web/static/src/js/chrome/action_manager_act_window.js:353:11
_executeWindowAction/<@http://oca-account-financial-tools-13-0-pr1438-82728466fadf.runboat.odoo-community.org/web/static/src/js/chrome/action_manager_act_window.js:258:3
0
Not working on runboat nor when trying to install it in local, so it's not possible to test it functionally. Please check previous review.
I just tested it on runbot. I had to install account_lock_date_update
which was missing on some view for any reason.
@chienandalu you can check now. Data is computed in a absolute way record per record with an aggregated SQL, but it's efficient enough on real databases, and it's the only way to get proper data no matter done filters.
@chienandalu you can check now. Data is computed in a absolute way record per record with an aggregated SQL, but it's efficient enough on real databases, and it's the only way to get proper data no matter done filters.
And won't it produce tons of queries?
As you visualize a limited number of records in these views, that would be the number of queries. It can't be avoided due to the nature of the need.
/ocabot merge nobump
What a great day to merge this nice PR. Let's do it! Prepared branch 13.0-ocabot-merge-pr-1438-by-pedrobaeza-bump-nobump, awaiting test results.
Congratulations, your PR was merged at 96cbdd4b54c507edc17a3b616f6057441fd1b390. Thanks a lot for contributing to OCA. ❤️