account-financial-tools
account-financial-tools copied to clipboard
OCA
[MIG] account_cost_center: Migration to 15.0
Hello, thanks for contributing. Please make sure you follow the guideline in order to migrate https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0#technical-method-to-migrate-a-module-from-140-to-150-branch
Hello, thanks for contributing. Please make sure you follow the guideline in order to migrate https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0#technical-method-to-migrate-a-module-from-140-to-150-branch
@kittiu, this module is ready to merge, please have a look.
@smemon786 it seems this PR is only 1 commit, but I suspect it should be several, in order to maintain the original history of the module.
The link you've added is for migrating a module that existed in 14.0 to 15.0. But it looks like account_cost_center hasn't been in the repo since version 12.0.
I think you need to adapt the commands you linked to use branch 12.0 where they refer to 14.0. That way you'll retain the proper git history of the module.
I basically think the first set of commands should be
$ git clone https://github.com/OCA/$REPO -b 15.0
$ cd $REPO
$ git checkout -b 15.0-mig-$MODULE origin/15.0
$ git format-patch --keep-subject --stdout origin/15.0..origin/12.0 -- $MODULE | git am -3 --keep
$ pre-commit run -a # to run black, isort and prettier (ignore pylint errors at this stage)
$ git add -A
$ git commit -m "[IMP] $MODULE: black, isort, prettier" --no-verify # it is important to do all formatting in one commit the first time
@smemon786 it seems this PR is only 1 commit, but I suspect it should be several, in order to maintain the original history of the module.
The link you've added is for migrating a module that existed in 14.0 to 15.0. But it looks like
account_cost_centerhasn't been in the repo since version 12.0.I think you need to adapt the commands you linked to use branch
12.0where they refer to14.0. That way you'll retain the proper git history of the module.I basically think the first set of commands should be
$ git clone https://github.com/OCA/$REPO -b 15.0 $ cd $REPO $ git checkout -b 15.0-mig-$MODULE origin/15.0 $ git format-patch --keep-subject --stdout origin/15.0..origin/12.0 -- $MODULE | git am -3 --keep $ pre-commit run -a # to run black, isort and prettier (ignore pylint errors at this stage) $ git add -A $ git commit -m "[IMP] $MODULE: black, isort, prettier" --no-verify # it is important to do all formatting in one commit the first time
@aisopuro, please review now.
OK, I will test this PR tomorrow. For make sure it work properly in v15! @kittiu
This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 15.0-ocabot-merge-pr-1384-by-kittiu-bump-nobump, awaiting test results.
Congratulations, your PR was merged at 41c0a10294f186a5f17c61f6ec863195cd9cb7b1. Thanks a lot for contributing to OCA. ❤️